fix: plugin api

Author: Ajit Kumar

.prettierrc

@@ -3,7 +3,17 @@
   "vcs": { "enabled": false, "clientKind": "git", "useIgnoreFile": false },
   "files": {
     "ignoreUnknown": true,
-    "includes": ["**", "!**/*.css", "!**/public/**/*", "!**/*.d.ts", "!**/.vscode/**/*", "!**/jsconfig.json", "!**/.babelrc", "!**/.hintrc"]
+    "includes": [
+      "**",
+      "!**/data/*",
+      "!**/*.css",
+      "!**/public/**/*",
+      "!**/*.d.ts",
+      "!**/.vscode/**/*",
+      "!**/jsconfig.json",
+      "!**/.babelrc",
+      "!**/.hintrc"
+    ]
   },
   "formatter": {
     "enabled": true,

biome.json

@@ -140,12 +140,7 @@ router.post('/', async (req, res) => {
       return;
     }
 
-    await Comment.insert(
-      [Comment.PLUGIN_ID, pluginId],
-      [Comment.USER_ID, loggedInUser.id],
-      [Comment.COMMENT, comment],
-      [Comment.VOTE, vote],
-    );
+    await Comment.insert([Comment.PLUGIN_ID, pluginId], [Comment.USER_ID, loggedInUser.id], [Comment.COMMENT, comment], [Comment.VOTE, vote]);
 
     if (vote !== Comment.VOTE_NULL) {
       updateVoteInPlugin(vote, pluginId);

server/apis/comment.js

@@ -382,7 +382,7 @@ router.post('/', async (req, res) => {
       return;
     }
 
-    const { name, price, version, minVersionCode } = pluginJson;
+    const { name, price, version, minVersionCode = -1 } = pluginJson;
 
     if (!VERSION_REGEX.test(version)) {
       res.status(400).send({
@@ -392,7 +392,7 @@ router.post('/', async (req, res) => {
     }
 
     if (typeof minVersionCode !== 'number') {
-      res.status(400).send({ error: 'minVersionCode should be a number' });
+      res.status(400).send({ error: `minVersionCode should be a number but got ${typeof minVersionCode}` });
       return;
     }
 

server/apis/plugin.js

@@ -312,7 +312,7 @@ route.post('/payment-method', async (req, res) => {
 
     const count = await PaymentMethod.count([PaymentMethod.USER_ID, loggedInUser.id]);
     insert.push([PaymentMethod.USER_ID, loggedInUser.id]);
-    await PaymentMethod.insert(...insert, [PaymentMethod.IS_DEFAULT, count === 0]);
+    await PaymentMethod.insert(...insert, [PaymentMethod.IS_DEFAULT, count === 0 ? 1 : 0]);
     res.send({ message: 'Payment method added' });
   } catch (error) {
     handleError(res, error);
@@ -434,15 +434,19 @@ route.put('/', async (req, res) => {
     }
 
     if (email) {
-      const row = await User.get([User.EMAIL, email]);
+      if (!sentOtp) {
+        res.status(400).send({ error: 'Missing OTP' });
+        return;
+      }
 
+      const row = await User.get([User.EMAIL, email]);
       if (row.length) {
         res.status(400).send({ error: 'User already' });
         return;
       }
 
-      const [{ otp: storedOtp }] = await Otp.get([Otp.EMAIL, email]);
-      if (storedOtp !== sentOtp) {
+      const [otpRow] = await Otp.get([Otp.EMAIL, email]);
+      if (otpRow?.otp !== sentOtp) {
         res.status(400).send({ error: 'Invalid OTP' });
         return;
       }

server/apis/user.js

@@ -136,7 +136,15 @@ class Plugin extends Entity {
     return this.update([this.STATUS, this.STATUS_INACTIVE], where, operator);
   }
 
-  deletePermanently(where, operator = 'AND') {
+  async deletePermanently(where, operator = 'AND') {
+    const [row] = await this.get(this.allColumns, where, operator);
+    if (!row) {
+      throw new Error('Plugin not found');
+    }
+
+    await Entity.execSql('DELETE FROM comment WHERE plugin_id = ?', [row.id]);
+    await Entity.execSql('DELETE FROM download WHERE plugin_id = ?', [row.id]);
+
     return super.delete(where, operator);
   }
 

server/entities/plugin.js

@@ -58,6 +58,15 @@ class User extends Entity {
     }
   }
 
+  async delete(where, operator = 'AND') {
+    const [row] = await this.get(this.allColumns, where, operator);
+    if (!row) {
+      throw new Error('User not found');
+    }
+
+    return super.delete(where, operator);
+  }
+
   get columns() {
     return [
       this.ID,

server/entities/user.js

@@ -11,4 +11,9 @@ if (!fs.existsSync(dbFile)) {
   fs.writeFileSync(dbFile, '');
 }
 
-module.exports = sqlite3(dbFile);
+const db = sqlite3(dbFile);
+
+// Enable foreign key constraints
+db.pragma('foreign_keys = ON');
+
+module.exports = db;

server/lib/db.js

@@ -34,4 +34,4 @@ const queries = ['ALTER TABLE sponsor ADD COLUMN tagline TEXT'];
   });
 
   process.exit(0);
-})();
+})();