JDTLS example is not quite right

[s1n7ax]

Checklist

• I have searched through the AstroNvim docs
• I have searched through the existing issues of AstroNvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.4

Operating system/version

NixOs 23

Terminal/GUI

Alacritty

Describe the bug

In the example given in https://docs.astronvim.com/recipes/advanced_lsp/#java-nvim-jdtls a new folder is created every time neovim is executed. And it concatenates the cwd so a new folder will be created by the name of the cwd even if it's not a java project.

local project_name = vim.fn.fnamemodify(vim.fn.getcwd(), ":p:h:t")
local workspace_dir = vim.fn.stdpath "data" .. "/site/java/workspace-root/" .. project_name

os.execute("mkdir " .. workspace_dir)

Additionally, os.execute does not work when the shell is nushell. Error of that actually visible for 200ms. I had to record and go frame by frame to read the error message. vim.fn.mkdir() probably a good alternative.

Steps to Reproduce

.

Expected behavior

.

Screenshots

No response

Additional Context

No response

[mehalter]

Thanks for reporting! If you have a better solution definitely make a PR :) We are currently on a doc freeze while we prepare for the v4 release. But if you open something up or give a better solution here I can incorporate it. Also, you could take a look at the AstroCommunity java pack and see if that's a better solution. We could upstream that config

[Ferenc-]

By now the JDTLS example has a more basic issue:

astovim vim/shared.lua:0: after the second argument: expected table, got function