Skip to content

Commit fd94d0a

Browse files
Adding '-1' to 902__n and 902__d for header in tind csv for Tind batch load (#34)
1 parent f26f811 commit fd94d0a

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

app/lib/tind_spread/make_batch.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module TindSpread
66
module MakeBatch
77

88
def self.added_headers(form_params)
9-
added_headers = %i[336__a 852__c 540__a 980__a 982__a 982__b 982__p 991__a 902__n]
9+
added_headers = %i[336__a 852__c 540__a 980__a 982__a 982__b 982__p 991__a]
1010
form_params.select { |key| added_headers.include?(key) }
1111
end
1212

@@ -25,7 +25,8 @@ def self.make_header(header, form_params, remove_filename: true)
2525
CSV.generate do |csv|
2626
h = header.concat(added_headers(form_params).keys.to_a)
2727
h << '035__a'
28-
h << '902__d'
28+
h << '902__n-1'
29+
h << '902__d-1'
2930
csv << h
3031
end
3132
# csv_string
@@ -64,6 +65,7 @@ def self.add_row(row, form_params, filename_row: false)
6465
csv_row << value
6566
end
6667
csv_row << make_035(form_params[:'980__a'], row)
68+
csv_row << form_params[:'902__n']
6769
csv_row << Time.current.in_time_zone('Pacific Time (US & Canada)').to_date
6870

6971
csv << csv_row

spec/lib/tind_spread/make_batch_spec.rb

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,14 @@
1616
it 'generates a CSV header combining spreadsheet headers and form params' do
1717
header = %w[Header1 Header2]
1818
form_params = { '336__a': 'value1', '852__c': 'value2' }
19-
expected_result = "Header1,Header2,336__a,852__c,035__a,902__d\n"
19+
expected_result = "Header1,Header2,336__a,852__c,035__a,902__n-1,902__d-1\n"
20+
expect(described_class.make_header(header, form_params)).to eq(expected_result)
21+
end
22+
23+
it 'includes 902__n-1 and 902__d-1 so they group on the same field' do
24+
header = %w[Header1]
25+
form_params = { '336__a': 'value1', '902__n': 'DMZ' }
26+
expected_result = "Header1,336__a,035__a,902__n-1,902__d-1\n"
2027
expect(described_class.make_header(header, form_params)).to eq(expected_result)
2128
end
2229
end
@@ -40,9 +47,9 @@
4047
describe '.add_row' do
4148
it 'adds a row to the CSV string with form params and additional fields' do
4249
row = { 'Header1' => 'Data1', 'Header2' => 'Data2' }
43-
form_params = { '980__a': 'VTI', '336__a': 'value1', '852__c': 'value2' }
50+
form_params = { '980__a': 'VTI', '336__a': 'value1', '852__c': 'value2', '902__n': 'DMZ' }
4451
allow(Time).to receive(:current).and_return(Time.parse('2023-10-01 12:00:00 UTC'))
45-
expected_result = "Data1,Data2,VTI,value1,value2,(VTI)file,2023-10-01\n"
52+
expected_result = "Data1,Data2,VTI,value1,value2,(VTI)file,DMZ,2023-10-01\n"
4653
allow(described_class).to receive(:get_first_fft).with(row).and_return('file.txt')
4754
expect(described_class.add_row(row, form_params)).to eq(expected_result)
4855
end

0 commit comments

Comments
 (0)