Skip to content

Commit 64795fa

Browse files
committed
Clean up
1 parent e2a6d4c commit 64795fa

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

ci/scripts/cpp_test.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ if ! type minio >/dev/null 2>&1; then
5555
fi
5656
case "$(uname)" in
5757
Linux)
58-
# -AL- check CI output not segfault right away.
59-
# exclude_tests+=("arrow-flight-sql-odbc-test")
58+
exclude_tests+=("arrow-flight-sql-odbc-test")
6059
n_jobs=$(nproc)
6160
;;
6261
Darwin)

compose.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -566,6 +566,7 @@ services:
566566
ARROW_PARQUET: "OFF"
567567
ARROW_S3: "OFF"
568568
ARROW_SUBSTRAIT: "OFF"
569+
# GH-49651 Link ODBC tests statically on Linux to fix segfault
569570
ARROW_TEST_LINKAGE: "static"
570571
# Register ODBC before running tests
571572
command: >

cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ set(ARROW_FLIGHT_SQL_ODBC_TEST_SRCS
4242
# GH-46889: move protobuf_test_util to a more common location
4343
../../../../engine/substrait/protobuf_test_util.cc)
4444

45+
# GH-49652: TODO support static test linkage on macOS
4546
if(ARROW_TEST_LINKAGE STREQUAL "static")
4647
set(ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS arrow_flight_sql_odbc_static
4748
${ARROW_TEST_STATIC_LINK_LIBS})
@@ -65,12 +66,13 @@ else()
6566
# Unix
6667
list(APPEND ARROW_FLIGHT_SQL_ODBC_TEST_STATIC_LINK_LIBS
6768
${ARROW_FLIGHT_SQL_ODBC_TEST_LIBS} ${ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS})
68-
69+
6970
if(NOT APPLE)
70-
# Explicitly link to boost on Linux // -AL- trying to make `ARROW_TEST_LINKAGE=static` work.
71-
list(APPEND ARROW_FLIGHT_SQL_ODBC_TEST_STATIC_LINK_LIBS arrow_odbc_spi_impl Boost::headers ${ARROW_PROTOBUF_LIBPROTOBUF})
71+
# Links static dependencies on Linux to support ARROW_TEST_LINKAGE=static
72+
list(APPEND ARROW_FLIGHT_SQL_ODBC_TEST_STATIC_LINK_LIBS arrow_odbc_spi_impl
73+
${ARROW_PROTOBUF_LIBPROTOBUF})
7274
endif()
73-
75+
7476
endif()
7577

7678
add_arrow_test(flight_sql_odbc_test

0 commit comments

Comments
 (0)