refactor(memtrack): use common lib paths for all allocators

Author: not-matthias

crates/memtrack/src/allocators/dynamic.rs

@@ -1,70 +1,43 @@
 use crate::{AllocatorKind, AllocatorLib};
 use std::path::PathBuf;
 
-/// Returns the glob patterns used to find this allocator's shared libraries.
-fn get_allocator_paths(lib: &AllocatorKind) -> &'static [&'static str] {
-    match lib {
-        AllocatorKind::Libc => &[
-            // Debian, Ubuntu: Standard Linux multiarch paths
-            "/lib/*-linux-gnu/libc.so.6",
-            "/usr/lib/*-linux-gnu/libc.so.6",
+impl AllocatorKind {
+    /// Build glob patterns for finding this allocator's shared libraries.
+    fn search_patterns(&self) -> Vec<String> {
+        const LIB_DIRS: &[&str] = &[
+            // Debian, Ubuntu: multiarch paths
+            "/lib/*-linux-gnu",
+            "/usr/lib/*-linux-gnu",
             // RHEL, Fedora, CentOS, Arch
-            "/lib*/libc.so.6",
-            "/usr/lib*/libc.so.6",
-            // NixOS: find all glibc versions in the Nix store
-            "/nix/store/*glibc*/lib/libc.so.6",
-        ],
-        AllocatorKind::LibCpp => &[
-            // Standard Linux multiarch paths
-            "/lib/*-linux-gnu/libstdc++.so*",
-            "/usr/lib/*-linux-gnu/libstdc++.so*",
-            // RHEL, Fedora, CentOS, Arch
-            "/lib*/libstdc++.so*",
-            "/usr/lib*/libstdc++.so*",
-            // NixOS: find all gcc lib versions in the Nix store
-            "/nix/store/*gcc*/lib/libstdc++.so*",
-        ],
-        AllocatorKind::Jemalloc => &[
-            // Debian, Ubuntu: Standard Linux multiarch paths
-            "/lib/*-linux-gnu/libjemalloc.so*",
-            "/usr/lib/*-linux-gnu/libjemalloc.so*",
-            // RHEL, Fedora, CentOS, Arch
-            "/lib*/libjemalloc.so*",
-            "/usr/lib*/libjemalloc.so*",
-            "/usr/local/lib*/libjemalloc.so*",
-            // NixOS
-            "/nix/store/*jemalloc*/lib/libjemalloc.so*",
-        ],
-        AllocatorKind::Mimalloc => &[
-            // Debian, Ubuntu: Standard Linux multiarch paths
-            "/lib/*-linux-gnu/libmimalloc.so*",
-            "/usr/lib/*-linux-gnu/libmimalloc.so*",
-            // RHEL, Fedora, CentOS, Arch
-            "/lib*/libmimalloc.so*",
-            "/usr/lib*/libmimalloc.so*",
-            "/usr/local/lib*/libmimalloc.so*",
-            // NixOS
-            "/nix/store/*mimalloc*/lib/libmimalloc.so*",
-        ],
-        AllocatorKind::Tcmalloc => &[
-            // gperftools tcmalloc variants
-            // Debian, Ubuntu: Standard Linux multiarch paths
-            "/lib/*-linux-gnu/libtcmalloc.so*",
-            "/lib/*-linux-gnu/libtcmalloc_minimal.so*",
-            "/lib/*-linux-gnu/libtcmalloc_debug.so*",
-            "/lib/*-linux-gnu/libtcmalloc_and_profiler.so*",
-            "/usr/lib/*-linux-gnu/libtcmalloc.so*",
-            "/usr/lib/*-linux-gnu/libtcmalloc_minimal.so*",
-            "/usr/lib/*-linux-gnu/libtcmalloc_debug.so*",
-            "/usr/lib/*-linux-gnu/libtcmalloc_and_profiler.so*",
-            // RHEL, Fedora, CentOS, Arch
-            "/lib*/libtcmalloc*.so*",
-            "/usr/lib*/libtcmalloc*.so*",
-            "/usr/local/lib*/libtcmalloc*.so*",
-            // NixOS
-            "/nix/store/*tcmalloc*/lib/libtcmalloc*.so*",
-            "/nix/store/*gperftools*/lib/libtcmalloc*.so*",
-        ],
+            "/lib*",
+            "/usr/lib*",
+            // Local installs
+            "/usr/local/lib*",
+        ];
+
+        let (filenames, nix_hints): (&[&str], &[&str]) = match self {
+            AllocatorKind::Libc => (&["libc.so.6"], &["glibc"]),
+            AllocatorKind::LibCpp => (&["libstdc++.so*"], &["gcc"]),
+            AllocatorKind::Jemalloc => (&["libjemalloc.so*"], &["jemalloc"]),
+            AllocatorKind::Mimalloc => (&["libmimalloc.so*"], &["mimalloc"]),
+            AllocatorKind::Tcmalloc => (&["libtcmalloc*.so*"], &["tcmalloc", "gperftools"]),
+        };
+
+        let mut patterns = Vec::new();
+
+        for dir in LIB_DIRS {
+            for filename in filenames {
+                patterns.push(format!("{dir}/{filename}"));
+            }
+        }
+
+        for hint in nix_hints {
+            for filename in filenames {
+                patterns.push(format!("/nix/store/*{hint}*/lib/{filename}"));
+            }
+        }
+
+        patterns
     }
 }
 
@@ -78,8 +51,8 @@ pub fn find_all() -> anyhow::Result<Vec<AllocatorLib>> {
     for kind in AllocatorKind::all() {
         let mut found_any = false;
 
-        for pattern in get_allocator_paths(kind) {
-            let paths = glob::glob(pattern)
+        for pattern in kind.search_patterns() {
+            let paths = glob::glob(&pattern)
                 .ok()
                 .into_iter()
                 .flatten()