Skip to content

Commit 6f597e4

Browse files
authored
Merge pull request #24 from Code4GovTech/sasi_dev_v2fix
org details fix
2 parents facbeaa + 2350586 commit 6f597e4

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def get_issues():
136136
issues = org['dmp_issues']
137137
obj['org_id'] = org['id']
138138
obj['org_name'] = org['name']
139-
renamed_issues = [{"id": issue["issue_number"], "name": issue["title"]} for issue in issues]
139+
renamed_issues = [{"id": issue["id"], "name": issue["title"]} for issue in issues]
140140
obj['issues'] = renamed_issues
141141

142142
res.append(obj)

v2_app.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def get_issues_by_owner_id_v2(owner, issue):
2525
url = f"https://github.com/{repo_owner}" if repo_owner else None
2626

2727

28-
dmp_issue_id = SUPABASE_DB.client.table('dmp_issues').select('*').like('issue_url', f'%{url}%').eq('issue_number', issue).execute()
28+
dmp_issue_id = SUPABASE_DB.client.table('dmp_issues').select('*').like('issue_url', f'%{url}%').eq('id', issue).execute()
2929
if not dmp_issue_id.data:
3030
return jsonify({'error': "No data found"}), 500
3131

@@ -46,9 +46,8 @@ def get_issues_by_owner_id_v2(owner, issue):
4646
# week_avg ,cont_name,cont_id,w_goal,w_learn,weekby_avgs,org_link = find_week_avg(issue_url)
4747
# mentors_data = find_mentors(val['issue_url']) if val['issue_url'] else {'mentors': [], 'mentor_usernames': []}
4848

49-
if val['body_text']:
50-
# and ("@"+val['created_by'].lower() == dmp_issue_id['mentor_username'].lower())
51-
if ("Weekly Goals" in val['body_text'] and not w_goal_url):
49+
if val['body_text']:
50+
if ("Weekly Goals" in val['body_text'] and not w_goal_url) and ("@"+val['created_by'].lower() == dmp_issue_id['mentor_username'].lower() if dmp_issue_id['mentor_username'] else None):
5251
w_goal_url = val['body_text']
5352
plain_text_body = markdown2.markdown(val['body_text'])
5453
tasks = re.findall(r'\[(x| )\]', plain_text_body)
@@ -73,7 +72,7 @@ def get_issues_by_owner_id_v2(owner, issue):
7372
"mentor_id": dmp_issue_id['mentor_username'] ,
7473
"contributor":define_link_data(cont_details),
7574
# "contributor_id": cont_details[0]['contributor_id'],
76-
"org": define_link_data(dmp_issue_id['mentor_username'])[0] if dmp_issue_id['mentor_username'] else [],
75+
"org": define_link_data(repo_owner),
7776
"weekly_goals_html": w_goal_url,
7877
"weekly_learnings_html": w_learn_url,
7978
"overall_progress":calculate_overall_progress(week_data,12),

0 commit comments

Comments
 (0)