Skip to content

Commit f334de6

Browse files
authored
fix: lint (#655)
# Description Fixes various warnings from lint that have been around awhile <!-- Please provide a general summary of your PR changes and link any related issues or other pull requests. --> # Testing <!-- Please provide details on how you tested this code. See below. - All pull requests must be tested (unit tests where possible with accompanying cassettes, or provide a screenshot of end-to-end testing when unit tests are not possible) - New features must get a new unit test - Bug fixes/refactors must re-record existing cassettes --> # Pull Request Type Please select the option(s) that are relevant to this PR. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Improvement (fixing a typo, updating readme, renaming a variable name, etc)
1 parent 8aa140e commit f334de6

9 files changed

Lines changed: 16 additions & 3 deletions

File tree

EasyPost/Models/API/Options.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
using EasyPost.Utilities.Internal.Extensions;
55
using Newtonsoft.Json;
66

7+
#pragma warning disable CS1591
8+
79
namespace EasyPost.Models.API
810
{
911
/// <summary>

EasyPost/Models/API/Pickup.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ public class Pickup : EasyPostObject, Parameters.IPickupParameter
6666
[JsonProperty("min_datetime")]
6767
public DateTime? MinDatetime { get; set; }
6868

69+
/// <summary>
70+
/// The name of the person to pick up the package.
71+
/// </summary>
6972
[JsonProperty("name")]
7073
public string? Name { get; set; }
7174

EasyPost/Models/API/PostageLabel.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
using EasyPost._base;
33
using Newtonsoft.Json;
44

5+
#pragma warning disable CS1591
6+
57
namespace EasyPost.Models.API
68
{
79
/// <summary>

EasyPost/Models/API/ReferralCustomer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
using EasyPost.Models.Shared;
55
using Newtonsoft.Json;
66

7+
#pragma warning disable CS1591
8+
79
namespace EasyPost.Models.API
810
{
911
#pragma warning disable CA1724 // Naming conflicts with Parameters.ReferralCustomer

EasyPost/Models/API/User.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
using EasyPost._base;
33
using Newtonsoft.Json;
44

5+
#pragma warning disable CS1591
6+
57
namespace EasyPost.Models.API
68
{
79
#pragma warning disable CA1724 // Naming conflicts with Parameters.User

EasyPost/Parameters/CarrierAccount/CreateOauth.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
using EasyPost.Utilities.Internal.Attributes;
44
using EasyPost.Utilities.Internal.Extensions;
55

6+
#pragma warning disable CS0618
7+
68
namespace EasyPost.Parameters.CarrierAccount
79
{
810
/// <summary>

EasyPost/Parameters/Luma/Buy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace EasyPost.Parameters.Luma
44
{
55
/// <summary>
6-
/// <a href="https://docs.easypost.com/docs/luma#standard-buy">Parameters</a> for <see cref="EasyPost.Services.ShipmentService.BuyLuma(Buy, System.Threading.CancellationToken)"/> API calls.
6+
/// <a href="https://docs.easypost.com/docs/luma#standard-buy">Parameters</a> for <see cref="EasyPost.Services.ShipmentService.BuyLuma(string, Buy, System.Threading.CancellationToken)"/> API calls.
77
/// </summary>
88
public class Buy : BaseParameters<Models.API.Shipment>
99
{

EasyPost/Parameters/Luma/CreateAndBuy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace EasyPost.Parameters.Luma
66
{
77
/// <summary>
8-
/// <a href="https://docs.easypost.com/docs/luma#one-call-buy">Parameters</a> for <see cref="EasyPost.Services.ShipmentService.CreateAndBuyLuma(Buy, System.Threading.CancellationToken)"/> API calls.
8+
/// <a href="https://docs.easypost.com/docs/luma#one-call-buy">Parameters</a> for <see cref="EasyPost.Services.ShipmentService.CreateAndBuyLuma(CreateAndBuy, System.Threading.CancellationToken)"/> API calls.
99
/// </summary>
1010
[ExcludeFromCodeCoverage]
1111
public class CreateAndBuy : BaseParameters<Models.API.Shipment>

EasyPost/Parameters/User/AllChildren.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class AllChildren : BaseAllParameters<Models.API.User>
1414
#region Request Parameters
1515

1616
/// <summary>
17-
/// Only records created after the given ID will be included. May not be used with <see cref="BeforeId"/>.
17+
/// Only records created after the given ID will be included.
1818
/// </summary>
1919
[TopLevelRequestParameter(Necessity.Optional, "after_id")]
2020
public string? AfterId { get; set; }

0 commit comments

Comments
 (0)