Fix light account/backup notification banner display behavior

Author: Jon-edge

CHANGELOG.md

@@ -10,6 +10,7 @@
 - added: Zcash buy/sell support with Banxa
 - changed: Optimize login performance.
 - changed: Update Monero LWS server name to "Edge LWS"
+- fixed: Light account/backup reminder notification banner sometimes missing on login
 
 ## 4.41.1 (2025-12-29)
 

src/actions/LocalSettingsActions.ts

@@ -261,6 +261,13 @@ export const writeTokenWarningsShown = async (
 export const readLocalAccountSettings = async (
   account: EdgeAccount
 ): Promise<LocalAccountSettings> => {
+  // If we've already read from disk, return the cached settings.
+  // This prevents stale disk reads from overwriting newer in-memory writes
+  // that may not have been persisted to disk yet.
+  if (readSettingsFromDisk) {
+    return localAccountSettings
+  }
+
   try {
     const text = await account.localDisklet.getText(LOCAL_SETTINGS_FILENAME)
     const json = JSON.parse(text)
@@ -273,6 +280,7 @@ export const readLocalAccountSettings = async (
     // Defaults can be derived from cleaners. Only write when values change.
     const defaults = asLocalAccountSettings({})
     emitAccountSettings(defaults)
+    readSettingsFromDisk = true
     return defaults
   }
 }

src/components/services/NotificationService.ts

@@ -146,6 +146,8 @@ export const NotificationService: React.FC<Props> = (props: Props) => {
   // Update notification info with
   // 1. Date last received if transitioning from incomplete to complete
   // 2. Reset `isBannerHidden` if it's a new notification
+  // NOTE: lightAccountReminder is handled by a separate effect below to
+  // avoid race conditions.
   useAsyncEffect(
     async () => {
       // New token(s) detected
@@ -165,11 +167,6 @@ export const NotificationService: React.FC<Props> = (props: Props) => {
       }
 
       await updateNotificationInfo(account, 'ip2FaReminder', isIp2faReminder)
-      await updateNotificationInfo(
-        account,
-        'lightAccountReminder',
-        isLightAccountReminder
-      )
       await updateNotificationInfo(
         account,
         'otpReminder',
@@ -201,12 +198,10 @@ export const NotificationService: React.FC<Props> = (props: Props) => {
     },
     [
       isIp2faReminder,
-      isLightAccountReminder,
       isOtpReminder,
       isPwReminder,
       wallets,
       detectedTokensRedux,
-      notifState,
       accountReferral,
       accountReferralLoaded,
       countryCode,
@@ -215,9 +210,11 @@ export const NotificationService: React.FC<Props> = (props: Props) => {
     'NotificationServices'
   )
 
-  // Make sure the backup banner is always shown on login if needed. We do this
-  // separately in this effect so that we can hide the banner during current
-  // login session if they so choose.
+  // Make sure the backup banner is always shown on login if needed. This is
+  // kept as a separate effect with minimal dependencies to avoid race
+  // conditions with the effect above. The dependency on isLightAccountReminder
+  // (which only changes at login) ensures this runs once per login.
+  // Users can still hide the banner during the current login session.
   useAsyncEffect(
     async () => {
       if (!isLightAccountReminder) return