Skip to content

Commit dc36282

Browse files
update
1 parent 811838a commit dc36282

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

.github/workflows/ios_emerge_upload_snapshots.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@ name: Emerge PR iOS Upload (Snapshots)
33
on:
44
push:
55
branches: [main]
6-
pull_request:
7-
branches: [main]
8-
paths: [ios/**, .github/workflows/ios*]
96

107
jobs:
118
upload_emerge_snapshots:

.github/workflows/ios_sentry_upload_snapshots.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ jobs:
2323

2424
- name: Generate snapshot images (iPhone)
2525
env:
26-
EMERGE_DEFAULT_DEVICE_NAME: iPhone 11 Pro Max
26+
EMERGE_DEFAULT_DEVICE_NAME: iPhone 17 Pro Max
2727
run: |
2828
set -o pipefail && xcodebuild test \
2929
-scheme HackerNews \
3030
-sdk iphonesimulator \
31-
-destination 'platform=iOS Simulator,name=iPhone 11 Pro Max' \
31+
-destination 'platform=iOS Simulator,name=iPhone 17 Pro Max' \
3232
-only-testing:HackerNewsTests/HackerNewsSnapshotTest \
3333
-resultBundlePath ../SnapshotResults-iphone.xcresult \
3434
ONLY_ACTIVE_ARCH=YES \
@@ -37,12 +37,12 @@ jobs:
3737
3838
- name: Generate snapshot images (iPad)
3939
env:
40-
EMERGE_DEFAULT_DEVICE_NAME: iPhone 11 Pro Max
40+
EMERGE_DEFAULT_DEVICE_NAME: iPhone 17 Pro Max
4141
run: |
4242
set -o pipefail && xcodebuild test \
4343
-scheme HackerNews \
4444
-sdk iphonesimulator \
45-
-destination 'platform=iOS Simulator,name=iPad Air (5th generation)' \
45+
-destination 'platform=iOS Simulator,name=iPad Air 11-inch (M3)' \
4646
-only-testing:HackerNewsTests/HackerNewsSnapshotTest \
4747
-resultBundlePath ../SnapshotResults-ipad.xcresult \
4848
ONLY_ACTIVE_ARCH=YES \

0 commit comments

Comments
 (0)