fix: Remove serverCore property

Author: osipxd

CHANGELOG.md

@@ -19,6 +19,10 @@ that simplifies plugin development by seamlessly integrating these plugins.
 - **Breaking change!**
   Use [jpenilla/run-task](https://github.com/jpenilla/run-task/) plugin and integrate run-paper for server execution,
   improving maintainability and compatibility with various server versions.
+  - Remove `bukkit.server.coreType` property.
+    Spigot is not supported anymore, PaperMC is the only supported server.
+    If you need to run other server cores,
+    please [file an issue](https://github.com/EndlessCodeGroup/BukkitGradle/issues/new).
 - **Breaking change!**
   Use [jpenilla/resource-factory](https://github.com/jpenilla/resource-factory) under the hood to generate `plugin.yml`.
   This change enables full configuration of `plugin.yml` from a build script, but it comes with some renaming:

README.md

@@ -253,9 +253,9 @@ bukkit {
 ### Upgrade from 0.10.x
 
 1. Update Gradle to 8.0 or newer (the latest version is recommended):
-```shell
-./gradlew wrapper --gradle-version 8.13
-```
+   ```shell
+   ./gradlew wrapper --gradle-version 8.13
+   ```
 
 2. Replace deprecated and removed APIs:
    ```diff
@@ -269,7 +269,10 @@ bukkit {
    }
    ``` 
 
-3. If you have `plugin.yml`, move it's content to `bukkit.plugin { ... }` block
+3. Remove server core selection: `bukkit.server.coreType` and `bukkit.server.setCore(...)`.
+   Paper is the only supported server core now.
+
+4. If you have `plugin.yml`, move it's content to `bukkit.plugin { ... }` block and delete the file.
 
 ### Upgrade from 0.8.x
 

src/main/kotlin/server/extension/CoreType.kt

@@ -9,7 +9,6 @@ public interface ServerConfiguration {
     public val encoding: String
     public val javaArgs: List<String>
     public val bukkitArgs: List<String>
-    public val coreType: CoreType
 
     /** Returns arguments for JVM. */
     public fun buildJvmArgs(): List<String>

src/main/kotlin/server/extension/ServerConfiguration.kt

@@ -2,7 +2,6 @@ package ru.endlesscode.bukkitgradle.server.extension
 
 import org.slf4j.Logger
 import org.slf4j.LoggerFactory
-import java.util.*
 
 public class ServerConfigurationImpl : ServerConfiguration {
 
@@ -17,25 +16,17 @@ public class ServerConfigurationImpl : ServerConfiguration {
     override var javaArgs: List<String> = listOf("-Xmx1G")
     override var bukkitArgs: List<String> = emptyList()
 
-    override var coreType: CoreType = CoreType.SPIGOT
-
-    /**
-     * Sets core from string.
-     * @see coreType
-     */
+    @Suppress("UNUSED_PARAMETER")
+    @Deprecated("Core selecting is not supported anymore. Paper is always used.")
     public fun setCore(core: String) {
-        try {
-            coreType = CoreType.valueOf(core.uppercase(Locale.ENGLISH))
-        } catch (_: IllegalArgumentException) {
-            logger.warn(
-                """
-                Core type '$core' not found. May be it doesn't supported by BukkitGradle yet.
-                Fallback core type is '${coreType.name}'.
-                Supported types: ${CoreType.values().joinToString(", ")}
-                Write an issue on GitHub to request support of other cores.
-                """.trimIndent()
-            )
-        }
+        logger.warn(
+            """
+            Server core selecting is not supported anymore. Paper is always used.
+            Please, remove `bukkit.server.setCore(...)` from your build script.
+            If you want to use other server core, file an issue:
+              https://github.com/EndlessCodeGroup/BukkitGradle/issues/new
+            """.trimIndent()
+        )
     }
 
     /** Append the given [args] to `javaArgs`. */
@@ -62,7 +53,6 @@ public class ServerConfigurationImpl : ServerConfiguration {
             ", encoding='$encoding'" +
             ", javaArgs='$javaArgs'" +
             ", bukkitArgs='$bukkitArgs'" +
-            ", coreType=$coreType" +
             "}"
     }
 

src/main/kotlin/server/extension/ServerConfigurationImpl.kt

@@ -19,28 +19,4 @@ class ServerConfigurationSpec extends Specification {
         then:
         ["-Dcom.mojang.eula.agree=true", "-Xmx1G"] == args
     }
-
-    void 'when set existing core - should set core successfully'() {
-        when:
-        serverConfiguration.core = "paper"
-
-        then:
-        CoreType.PAPER == serverConfiguration.coreType
-    }
-
-    void 'when set existing core in mixed case - should set core successfully'() {
-        when:
-        serverConfiguration.core = "Paper"
-
-        then:
-        CoreType.PAPER == serverConfiguration.coreType
-    }
-
-    void 'when set not existing core - should fallback to spigot core'() {
-        when:
-        serverConfiguration.core = "uber-bukkit"
-
-        then:
-        CoreType.SPIGOT == serverConfiguration.coreType
-    }
 }