fix: compare strings, not object references (#46)

joshua-rogers-exodus · web-flow · commit 184219d95655 · 2025-09-08T13:12:14.000+02:00
diff --git a/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java b/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
@@ -1079,7 +1079,7 @@ public void onPermissionRequest(final PermissionRequest request) {
       final int port = originUri.getPort();
       String origin = scheme + "://" + originUri.getHost();
 
-      if (port > 0 && ((scheme == "http" && port != 80) || (scheme == "https" && port != 443))) {
+      if (port > 0 && (("http".equals(scheme) && port != 80) || ("https".equals(scheme) && port != 443))) {
         origin += ":" + port;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -1079,7 +1079,7 @@ public void onPermissionRequest(final PermissionRequest request) {`
`1079`	`1079`	`final int port = originUri.getPort();`
`1080`	`1080`	`String origin = scheme + "://" + originUri.getHost();`
`1081`	`1081`
`1082`		`- if (port > 0 && ((scheme == "http" && port != 80) \|\| (scheme == "https" && port != 443))) {`
	`1082`	`+ if (port > 0 && (("http".equals(scheme) && port != 80) \|\| ("https".equals(scheme) && port != 443))) {`
`1083`	`1083`	`origin += ":" + port;`
`1084`	`1084`	`}`
`1085`	`1085`