[Due for payment 2026-04-20] [$250] Don't show non-reimbursable reports in the `Pay` to-do queu

[JmillsExpensify]

Based on this discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1775572675172489.

Issue Owner

Current Issue Owner: @situchan

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022041816085132038141
• Upwork Job ID: 2041816085132038141
• Last Price Increase: 2026-04-08
• Automatic offers:
• twilight2294 | Contributor | 111039559

[samranahm]

I recently worked on this, I'm open to this one too.

cc:@situchan

[MelvinBot]

Proposal

What is the root cause of that problem?

The Pay to-do queue count is driven by isPrimaryPayAction() in ReportPrimaryActionUtils.ts:225-230. The condition explicitly includes reports that have only non-reimbursable transactions:

(reimbursableSpend !== 0 || (nonReimbursableSpend !== 0 && hasOnlyNonReimbursableTransactions(...)))

The second branch of that OR means any finished expense report where all transactions are non-reimbursable will appear in the Pay queue, even though there is nothing to reimburse.

Notably, the ForYouSection Pay handler already passes {reimbursable: YES} when navigating to search results (index.tsx:90), so the count and the actual search results are mismatched — the badge shows a number, but the results page filters those reports out.

What changes do you think we should make in order to solve the problem?

Remove the non-reimbursable branch from the condition in isPrimaryPayAction() at ReportPrimaryActionUtils.ts:230, changing:

(reimbursableSpend !== 0 || (nonReimbursableSpend !== 0 && hasOnlyNonReimbursableTransactions(report?.reportID, reportTransactions)))

to simply:

reimbursableSpend !== 0

This is safe because useNonReimbursablePaymentModal already blocks direct payment for non-reimbursable-only reports, confirming they should not have a Pay action.

What alternative solutions did you explore? (Optional)

An alternative would be to filter non-reimbursable reports only in the todo queue logic (todos.ts:67-79) rather than in isPrimaryPayAction itself. However, fixing it at the source (isPrimaryPayAction) is cleaner since the Pay action genuinely does not apply to non-reimbursable-only reports — the payment modal already blocks it.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022041816085132038141

[Abdullahtmk]

Please re-state the problem that we are trying to solve in this issue.

Non-reimbursable expense reports are appearing in the "Pay" to-do queue, but users cannot actually pay these reports since they are marked as non-reimbursable. This creates confusion and clutter in the to-do list.

What is the root cause of that problem?

The Pay to-do queue filtering logic (likely in src/libs/ReportUtils.ts or src/libs/TodoUtils.ts) doesn't exclude reports with reimbursable: false when determining which reports should appear in the Pay queue. The filter checks for report state (Outstanding, approved, etc.) but skips the reimbursable status check.

What changes do you think we should make in order to solve the problem?

In the to-do queue filter function (likely shouldShowPaymentReminderInTodoList() or similar in src/libs/ReportUtils.ts), add a check to exclude non-reimbursable reports:

// Before: Only checks report state
function shouldShowPaymentReminderInTodoList(report: Report): boolean {
    return isOutstandingReport(report) && isReportApproved(report);
}

// After: Also checks if reimbursable
function shouldShowPaymentReminderInTodoList(report: Report): boolean {
    return (
        isOutstandingReport(report) && 
        isReportApproved(report) && 
        report.reimbursable !== false // Exclude non-reimbursable
    );
}

Or if the logic is in a different filter path (e.g., getReportsToPayQueued() in actions), add the same reimbursable check there.

What alternative solutions did you explore? (Optional)

• Show non-reimbursable reports with disabled state: Still clutters the queue

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense reports where all transactions are non-reimbursable (e.g., company card expenses) appear in the Pay to-do queue, even though there is nothing to reimburse.

What is the root cause of that problem?

The Pay to-do queue is populated in todos by checking isPrimaryPayAction() in ReportPrimaryActionUtils. That function returns true for reports with only non-reimbursable transactions due to this condition:

reimbursableSpend !== 0 || (nonReimbursableSpend !== 0 && hasOnlyNonReimbursableTransactions(...))

The second branch was intentionally added to support "mark as paid" on non-reimbursable reports when viewing them directly. The problem is that the to-do queue also picks these up, creating a misleading Pay count.

What changes do you think we should make in order to solve the problem?

Filter out non-reimbursable-only reports in todos when building the reportsToPay list. After the isPrimaryPayAction() check, add a guard that excludes reports where hasOnlyNonReimbursableTransactions() is true:

if (primaryAction === CONST.REPORT.PRIMARY_ACTIONS.PAY && !hasOnlyNonReimbursableTransactions(report?.reportID, reportTransactions)) {
    reportsToPay.push(report);
}

What alternative solutions did you explore? (Optional)

MelvinBot's proposal removes the non-reimbursable branch from isPrimaryPayAction() entirely. That's over-scoped — the hasOnlyNonReimbursableTransactions branch was intentionally added (commit 55137f357ff) to allow "mark as paid" on non-reimbursable reports when a user views them directly. Gutting it from isPrimaryPayAction() would remove that capability everywhere, not just from the to-do queue. Filtering in todos.ts is more targeted: it fixes the to-do queue without regressing the direct report Pay/mark-as-paid flow.

[samarroy84]

🚨 Edited by proposal-police: This proposal was edited at 2026-04-08 10:47:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Non-reimbursable reports are displayed in the Pay to-do queue

What is the root cause of that problem?

App/src/libs/ReportPrimaryActionUtils.ts

Lines 225 to 233 in d1dbbcb

	if (
	isReportPayer &&
	isExpenseReport &&
	arePaymentsEnabled &&
	isReportFinished &&
	(reimbursableSpend !== 0 || (nonReimbursableSpend !== 0 && hasOnlyNonReimbursableTransactions(report?.reportID, reportTransactions)))
	) {
	return isSecondaryAction ?? !didExportFail;
	}

Here, return true if report has only non-reimbursable transactions with non-zero amount.

So this report is pushed to Pay todo section

App/src/libs/actions/OnyxDerived/configs/todos.ts

Lines 67 to 79 in d1dbbcb

	if (
	isPrimaryPayAction({
	report,
	reportTransactions,
	currentUserAccountID,
	currentUserLogin: login,
	bankAccountList,
	policy,
	reportNameValuePairs: reportNameValuePair,
	})
	) {
	reportsToPay.push(report);
	}

What changes do you think we should make in order to solve the problem?

In isPrimaryPayAction function, return false if report has only non-reimbursable transactions and if this is coming from todo section check.

if this is coming from todo section check.

We can introduce new isFromTodos flag in isPrimaryPayAction. This way, we don't need to recompute hasOnlyNonReimbursableTransactions in todo section.

App/src/libs/ReportPrimaryActionUtils.ts

Lines 225 to 233 in d1dbbcb

	if (
	isReportPayer &&
	isExpenseReport &&
	arePaymentsEnabled &&
	isReportFinished &&
	(reimbursableSpend !== 0 || (nonReimbursableSpend !== 0 && hasOnlyNonReimbursableTransactions(report?.reportID, reportTransactions)))
	) {
	return isSecondaryAction ?? !didExportFail;
	}

    if (isReportPayer && isExpenseReport && arePaymentsEnabled && isReportFinished) {
        if (reimbursableSpend !== 0) {
            return isSecondaryAction ?? !didExportFail;
        }
        if (hasOnlyNonReimbursableTransactions(report?.reportID, reportTransactions)) {
            return !isFromTodos && nonReimbursableSpend !== 0 && (isSecondaryAction ?? !didExportFail);
        }
    }

My proposal also removes redundant check here by early returning when hasOnlyNonReimbursableTransactions = true and nonReimbursableSpend = 0.

What alternative solutions did you explore? (Optional)

[JasimMalook]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.