Skip to content

Commit 5516c16

Browse files
author
Fernando López
committed
Resolving merge problems
2 parents a61fcfc + 8b7c7dc commit 5516c16

9 files changed

Lines changed: 305 additions & 303 deletions

File tree

doc/Refactoring.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,17 @@ This refactoring plan aims to improve modularity, maintainability, test clarity,
1616
- [ ] Code duplication
1717
- [ ] Docker reliability
1818
- [ ] BDD feature file readability
19+
- Missing tutorials:
20+
- NGSIv2:
21+
- [ ] 106. Subscribing to Changes in Context
22+
- NGSI-LD
23+
- [ ] 104. Concise Payloads
24+
- [ ] (@flopezag) 104. Entity Relationships refactor to 106. Entity Relationships
25+
- [ ] (@flopezag) 105. Merge-Patch and Put
26+
- [ ] 106. Subscription refactor to 107. Subscriptions
27+
- [ ] 108. Registrations
28+
- [ ] 109. Temporal Operations
29+
- [ ] 110. Extended Properties
1930

2031
---
2132

@@ -29,8 +40,11 @@ This refactoring plan aims to improve modularity, maintainability, test clarity,
2940
- [ ] NGSI-v2 and NGSI-LD split
3041
- [ ] Rename `config.json``ngsi_v2.json`, `ngsi_ld.json`
3142
- [ ] Group `.feature` files:
43+
3244
features/
45+
3346
├── ngsi_v2/
47+
3448
└── ngsi_ld/
3549
- [ ] Unify or reuse shared step definitions.
3650

features/403.Securing_Application_Access.feature

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Feature: Test tutorial 403.Securing application access
1313
Given I set "ClientID" to "tutorial-dckr-site-0000-xpresswebapp"
1414
And I set "ClientSecret" to "tutorial-dckr-site-0000-clientsecret"
1515
When I calculate the base64 of this ClientId and ClientSecret
16-
Then I obtain the value "dHV0b3JpYWwtZGNrci1zaXRlLTAwMDAteHByZXNzd2ViYXBwOnR1dG9yaWFsLWRja3Itc2l0ZS0wMDAwLWNsaWVudHNlY3JldAo=="
16+
Then I obtain the value "dHV0b3JpYWwtZGNrci1zaXRlLTAwMDAteHByZXNzd2ViYXBwOnR1dG9yaWFsLWRja3Itc2l0ZS0wMDAwLWNsaWVudHNlY3JldA=="
1717

1818
Scenario: 01 - Logging-in with a password
1919
When I set the Authorization header token with the calculated value
@@ -24,7 +24,7 @@ Feature: Test tutorial 403.Securing application access
2424
And I send a POST HTTP request to that url
2525
Then I receive a HTTP "200" status code from Keyrock with the following data
2626
| access_token | token_type | expires_in | refresh_token |
27-
| any | Bearer | 3599 | any |
27+
| any | bearer | 3599 | any |
2828

2929
Scenario: 02 - Retrieving user details from an access token
3030
When I set the the user url with the previous access_token
@@ -40,7 +40,7 @@ Feature: Test tutorial 403.Securing application access
4040
And I send a POST HTTP request to that url
4141
Then I receive a HTTP "200" status code from Keyrock with the following data
4242
| access_token | token_type | expires_in |
43-
| any | Bearer | 3599 |
43+
| any | bearer | 3599 |
4444

4545
Scenario: 04 - Availability check
4646
When I set the Authorization header token with the calculated value
@@ -51,7 +51,7 @@ Feature: Test tutorial 403.Securing application access
5151
And I send a POST HTTP request to that url
5252
Then I receive a HTTP "200" status code from Keyrock with the following data
5353
| access_token | token_type | expires_in | refresh_token |
54-
| any | Bearer | 3599 | any |
54+
| any | bearer | 3599 | any |
5555

5656
Scenario: 05 - Refresh access token
5757
When I set the Authorization header token with the calculated value
@@ -62,7 +62,7 @@ Feature: Test tutorial 403.Securing application access
6262
And I send a POST HTTP request to that url
6363
Then I receive a HTTP "200" status code from Keyrock with the following data
6464
| access_token | token_type | expires_in | refresh_token |
65-
| any | Bearer | 3599 | any |
65+
| any | bearer | 3599 | any |
6666

6767
# There should be clarified that Application ID is equal to Client ID in the tutorial
6868
# This scenario works basically because there is no response in the tutorial, therefore

features/data/101.Getting_started/response101-01.excludes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
root['orion']['orionld version']
2+
root['orion']['orion version']
13
root['orion']['version']
24
root['orion']['git_hash']
35
root['orion']['compile_time']

features/data/101.Getting_started/response101-01.json

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@
88
"compiled_in": "buildkitsandbox",
99
"release_date": "Mon Jun 12 16:55:20 UTC 2023",
1010
"machine": "x86_64",
11-
"doc": "https://fiware-orion.rtfd.io/en/3.10.1/",
12-
"libversions": {
13-
"boost": "1_74",
14-
"libcurl": "libcurl/7.74.0 OpenSSL/1.1.1n zlib/1.2.12 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.43.0 librtmp/2.3",
15-
"libmosquitto": "2.0.15",
16-
"libmicrohttpd": "0.9.76",
17-
"openssl": "1.1",
18-
"rapidjson": "1.1.0",
19-
"mongoc": "1.23.1",
20-
"bson": "1.23.1"
21-
}
11+
"doc": "https://fiware-orion.rtfd.io/en/3.10.1/"
2212
}
23-
}
13+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
root['orion']['orionld version']
2+
root['orion']['orion version']
3+
root['orion']['version']
4+
root['orion']['git_hash']
5+
root['orion']['compile_time']
6+
root['orion']['release_date']
7+
root['orion']['doc']
8+
root['orion']['uptime']

features/data/103.CRUD-Operations/response101-01.json

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@
88
"compiled_in": "buildkitsandbox",
99
"release_date": "Mon Jun 12 16:55:20 UTC 2023",
1010
"machine": "x86_64",
11-
"doc": "https://fiware-orion.rtfd.io/en/3.10.1/",
12-
"libversions": {
13-
"boost": "1_74",
14-
"libcurl": "libcurl/7.74.0 OpenSSL/1.1.1n zlib/1.2.12 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.43.0 librtmp/2.3",
15-
"libmosquitto": "2.0.15",
16-
"libmicrohttpd": "0.9.76",
17-
"openssl": "1.1",
18-
"rapidjson": "1.1.0",
19-
"mongoc": "1.23.1",
20-
"bson": "1.23.1"
21-
}
11+
"doc": "https://fiware-orion.rtfd.io/en/3.10.1/"
2212
}
23-
}
13+
}

0 commit comments

Comments
 (0)