Improve code readability

Author: velppa

analytics/client.py

@@ -45,15 +45,15 @@ def __init__(self, write_key=None, debug=False, max_queue_size=10000,
         self.debug = debug
         self.send = send
 
-        if transport not in ('http', 's3'):
+        if transport == 'http':
+            self.consumer = Consumer(self.queue, write_key, endpoint=endpoint,
+                                     on_error=on_error, upload_size=upload_size)
+        elif transport == 's3':
+            self.consumer = S3Consumer(self.queue, write_key, endpoint=endpoint,
+                                       on_error=on_error, upload_size=upload_size)
+        else:
             raise ValueError("transport should be either http or s3")
 
-        self.consumer = Consumer(self.queue, write_key, endpoint=endpoint,
-                                 on_error=on_error, upload_size=upload_size) \
-          if transport=='http' else \
-                        S3Consumer(self.queue, write_key, endpoint=endpoint,
-                                   on_error=on_error, upload_size=upload_size)
-
         if debug:
             self.log.setLevel(logging.DEBUG)
 

analytics/s3_consumer.py

@@ -150,7 +150,7 @@ def next(self):
         return written_items
 
     def _upload_request(self, attempt=0):
-        """Attempt to upload the data present in the buffer. It will throw AssertionError on failure."""
+        """Attempt to upload the data present in the buffer. It will throw Exception on failure."""
 
         bucket = self.s3_details['bucket']
         key = self.s3_details['key_template'] % (self.s3_details['part'])