Skip to content

Commit 8fab2d8

Browse files
committed
update comments for generic pcie device
This is updating comments for a generic PCIE device, repurposing one GPIO for a 12V regulator enable pin, and the other to power sequence the 3.3V PCIE power enable with system power on, to allow generic PCIE devices to be used. Signed-off-by: Kieran Levin <ktl@frame.work>
1 parent 1204a0e commit 8fab2d8

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

pcie.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ struct default_ssd_cfg pcie_accessory_cfg = {
1010
.hardware_version = 0x0008,
1111
.hardware_revision = 0,
1212
.serial = {'F', 'R', 'A', 'P', 'C', 'I', 'E', '0', '0', '0',
13-
'0', '0', '0', 'T', 'E', 'S', 'T', '1', '\0', '\0'},
13+
'0', '0', '0', 'T', 'E', 'S', 'T', '8', '\0', '\0'},
1414
.descriptor_length = sizeof(struct default_ssd_cfg) - sizeof(struct gpu_cfg_descriptor),
1515
.descriptor_crc32 = 0,
1616
.crc32 = 0
@@ -27,15 +27,15 @@ struct default_ssd_cfg pcie_accessory_cfg = {
2727
.hdr3 = {.block_type = GPUCFG_TYPE_VENDOR, .block_length = sizeof(enum gpu_vendor)},
2828
.vendor = GPU_PCIE_ACCESSORY,
2929

30-
/* Power enable for SSD1 */
30+
/* Power enable for 12V */
3131
.hdr4 = {.block_type = GPUCFG_TYPE_GPIO, .block_length = sizeof(struct gpu_cfg_gpio) * 8},
3232
.gpio0 = {.gpio = GPU_1G1_GPIO0_EC, .function = GPIO_FUNC_HIGH, .flags = GPIO_OUTPUT_LOW, .power_domain = POWER_S3},
33-
/* Power enable for SSD2 */
33+
/* Power enable for 3.3V */
3434
.gpio1 = {.gpio = GPU_1H1_GPIO1_EC, .function = GPIO_FUNC_HIGH, .flags = GPIO_OUTPUT_LOW, .power_domain = POWER_S3},
3535
/* UNUSED */
36-
.gpio2 = {.gpio = GPU_2A2_GPIO2_EC, .function = GPIO_FUNC_UNUSED, .flags = GPIO_OUTPUT_LOW, .power_domain = POWER_G3},
36+
.gpio2 = {.gpio = GPU_2A2_GPIO2_EC, .function = GPIO_FUNC_UNUSED, .flags = GPIO_INPUT, .power_domain = POWER_G3},
3737
/* UNUSED */
38-
.gpio3 = {.gpio = GPU_2L7_GPIO3_EC, .function = GPIO_FUNC_UNUSED, .flags = GPIO_OUTPUT_LOW, .power_domain = POWER_G3},
38+
.gpio3 = {.gpio = GPU_2L7_GPIO3_EC, .function = GPIO_FUNC_UNUSED, .flags = GPIO_INPUT, .power_domain = POWER_G3},
3939
/* set mux configuration on mainboard for SSD */
4040
.gpio_edpaux = {.gpio = GPU_PCIE_MUX_SEL, .function = GPIO_FUNC_HIGH, .flags = GPIO_OUTPUT_LOW, .power_domain = POWER_S3},
4141
/* GPU_VSYS_EN */

0 commit comments

Comments
 (0)