Skip to content

Commit a71f41d

Browse files
authored
Fix spacing in reactions menu header and media gallery preview icons (#6351)
* Update MediaGalleryPreviewScreen footer icons size * Update spacing in reactions menu header * Dump API * Update snapshots
1 parent 7b9fcd0 commit a71f41d

19 files changed

Lines changed: 11 additions & 9 deletions

File tree

stream-chat-android-compose/api/stream-chat-android-compose.api

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1646,8 +1646,8 @@ public final class io/getstream/chat/android/compose/ui/components/reactions/Rea
16461646
public final class io/getstream/chat/android/compose/ui/components/selectedmessage/ComposableSingletons$MessageMenuHeaderKt {
16471647
public static final field INSTANCE Lio/getstream/chat/android/compose/ui/components/selectedmessage/ComposableSingletons$MessageMenuHeaderKt;
16481648
public fun <init> ()V
1649+
public final fun getLambda$1595289781$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
16491650
public final fun getLambda$1869643284$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
1650-
public final fun getLambda$789360109$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
16511651
}
16521652

16531653
public final class io/getstream/chat/android/compose/ui/components/selectedmessage/ComposableSingletons$ReactionCountRowKt {

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/preview/MediaGalleryPreviewScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ internal fun MediaGalleryPreviewShareIcon(
873873
Icon(
874874
painter = painterResource(id = painter),
875875
contentDescription = stringResource(id = description),
876-
modifier = Modifier.size(24.dp),
876+
modifier = Modifier.size(20.dp),
877877
)
878878
}
879879
}
@@ -949,6 +949,7 @@ internal fun MediaGalleryPreviewPhotosIcon(
949949
Icon(
950950
painter = painterResource(id = R.drawable.stream_design_ic_gallery),
951951
contentDescription = stringResource(id = R.string.stream_compose_image_preview_photos),
952+
modifier = Modifier.size(20.dp),
952953
)
953954
}
954955
}

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/selectedmessage/MessageMenuHeader.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ package io.getstream.chat.android.compose.ui.components.selectedmessage
1818

1919
import androidx.compose.foundation.background
2020
import androidx.compose.foundation.border
21-
import androidx.compose.foundation.layout.Arrangement
2221
import androidx.compose.foundation.layout.Row
2322
import androidx.compose.foundation.layout.padding
2423
import androidx.compose.foundation.shape.CircleShape
2524
import androidx.compose.material3.Icon
25+
import androidx.compose.material3.minimumInteractiveComponentSize
2626
import androidx.compose.runtime.Composable
2727
import androidx.compose.ui.Alignment
2828
import androidx.compose.ui.Modifier
@@ -37,6 +37,7 @@ import io.getstream.chat.android.compose.ui.components.button.StreamButton
3737
import io.getstream.chat.android.compose.ui.components.button.StreamButtonSize
3838
import io.getstream.chat.android.compose.ui.components.button.StreamButtonStyleDefaults
3939
import io.getstream.chat.android.compose.ui.components.reactions.ReactionToggleSize
40+
import io.getstream.chat.android.compose.ui.theme.ChatPreviewTheme
4041
import io.getstream.chat.android.compose.ui.theme.ChatTheme
4142
import io.getstream.chat.android.compose.ui.theme.ReactionToggleParams
4243
import io.getstream.chat.android.compose.ui.theme.StreamTokens
@@ -71,9 +72,7 @@ public fun MessageMenuHeader(
7172
Row(
7273
modifier = modifier
7374
.background(colors.backgroundCoreElevation2, CircleShape)
74-
.border(1.dp, colors.borderCoreDefault, CircleShape)
75-
.padding(StreamTokens.spacing2xs),
76-
horizontalArrangement = Arrangement.spacedBy(StreamTokens.spacing3xs),
75+
.border(1.dp, colors.borderCoreDefault, CircleShape),
7776
verticalAlignment = Alignment.CenterVertically,
7877
) {
7978
options.forEach { option ->
@@ -84,7 +83,9 @@ public fun MessageMenuHeader(
8483
size = ReactionToggleSize.Large,
8584
checked = option.isSelected,
8685
onCheckedChange = { _ -> onReactionOptionSelected(option) },
87-
modifier = Modifier.testTag("Stream_Reaction_${option.type}"),
86+
modifier = Modifier
87+
.testTag("Stream_Reaction_${option.type}")
88+
.padding(start = StreamTokens.spacing3xs),
8889
),
8990
)
9091
}
@@ -94,7 +95,7 @@ public fun MessageMenuHeader(
9495
onClick = onShowMoreReactionsSelected,
9596
style = StreamButtonStyleDefaults.secondaryOutline,
9697
size = StreamButtonSize.Small,
97-
modifier = Modifier,
98+
modifier = Modifier.minimumInteractiveComponentSize(),
9899
) {
99100
Icon(
100101
painter = painterResource(R.drawable.stream_design_ic_plus),
@@ -108,7 +109,7 @@ public fun MessageMenuHeader(
108109
@Preview(showBackground = true)
109110
@Composable
110111
private fun MessageMenuHeaderPreview() {
111-
ChatTheme {
112+
ChatPreviewTheme {
112113
val reactionType = ChatTheme.reactionResolver.supportedReactions.firstOrNull()
113114

114115
if (reactionType != null) {
Loading
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)