Refactor group channel editing logic to move image selection and caching state from the UI to GroupChannelEditViewModel.

Author: andremion

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/GroupChannelEditScreen.kt

@@ -44,7 +44,6 @@ import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
-import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
@@ -74,12 +73,9 @@ import io.getstream.chat.android.compose.ui.theme.StreamTokens
 import io.getstream.chat.android.compose.ui.util.bottomBorder
 import io.getstream.chat.android.compose.viewmodel.channel.GroupChannelEditViewEvent
 import io.getstream.chat.android.compose.viewmodel.channel.GroupChannelEditViewModel
-import io.getstream.chat.android.core.internal.coroutines.DispatcherProvider
 import io.getstream.chat.android.models.Channel
 import io.getstream.chat.android.previewdata.PreviewChannelData
 import io.getstream.chat.android.ui.common.contract.internal.CaptureMediaContract
-import kotlinx.coroutines.launch
-import kotlinx.coroutines.withContext
 import java.io.File
 
 @OptIn(ExperimentalMaterial3Api::class)
@@ -95,9 +91,6 @@ internal fun GroupChannelEditScreen(
     var channelName by rememberSaveable(stateSaver = TextFieldValue.Saver) {
         mutableStateOf(TextFieldValue(text = channel.name, selection = TextRange(channel.name.length)))
     }
-    var pendingImagePath by rememberSaveable { mutableStateOf<String?>(null) }
-    val pendingImageFile = pendingImagePath?.let(::File)
-    var removeImage by rememberSaveable { mutableStateOf(false) }
     var showImagePicker by rememberSaveable { mutableStateOf(false) }
 
     LaunchedEffect(viewModel) {
@@ -115,6 +108,8 @@ internal fun GroupChannelEditScreen(
         }
     }
 
+    val pendingImageFile = state.pendingImageFile
+    val removeImage = state.removeImage
     val displayChannel = remember(channel, pendingImageFile, removeImage) {
         when {
             pendingImageFile != null -> channel.copy(image = Uri.fromFile(pendingImageFile).toString())
@@ -126,25 +121,20 @@ internal fun GroupChannelEditScreen(
     GroupChannelEditContent(
         channel = displayChannel,
         channelName = channelName,
-        isSaving = state.isSaving,
+        isBusy = state.isBusy,
         onChannelNameChange = { channelName = it },
         onNavigationIconClick = onDismiss,
-        onSaveActionClick = { viewModel.save(channelName.text, pendingImageFile, removeImage) },
+        onSaveActionClick = { viewModel.save(channelName.text) },
         onUploadPictureClick = { showImagePicker = true },
     )
 
     ImagePickerSheet(
         visible = showImagePicker,
         showRemoveOption = (channel.image.isNotBlank() || pendingImageFile != null) && !removeImage,
         onDismiss = { showImagePicker = false },
-        onImageSelected = { file ->
-            pendingImagePath = file.absolutePath
-            removeImage = false
-        },
-        onImageRemoved = {
-            pendingImagePath = null
-            removeImage = true
-        },
+        onGalleryUriPicked = viewModel::importGalleryImage,
+        onImageSelected = viewModel::setPendingImage,
+        onImageRemoved = viewModel::removeImage,
     )
 }
 
@@ -154,21 +144,14 @@ private fun ImagePickerSheet(
     visible: Boolean,
     showRemoveOption: Boolean,
     onDismiss: () -> Unit = {},
+    onGalleryUriPicked: (Uri) -> Unit = {},
     onImageSelected: (File) -> Unit = {},
     onImageRemoved: () -> Unit = {},
 ) {
-    val context = LocalContext.current
-    val scope = rememberCoroutineScope()
-
     val pickMediaLauncher = rememberLauncherForActivityResult(
         contract = ActivityResultContracts.PickVisualMedia(),
     ) { uri ->
-        uri ?: return@rememberLauncherForActivityResult
-        scope.launch(DispatcherProvider.IO) {
-            uri.toCacheFile(context)?.let { file ->
-                withContext(DispatcherProvider.Main) { onImageSelected(file) }
-            }
-        }
+        uri?.let(onGalleryUriPicked)
     }
 
     val capturePhotoLauncher = rememberCaptureMediaLauncher(
@@ -211,7 +194,7 @@ private fun ImagePickerSheet(
 private fun GroupChannelEditContent(
     channel: Channel,
     channelName: TextFieldValue,
-    isSaving: Boolean,
+    isBusy: Boolean = false,
     onChannelNameChange: (TextFieldValue) -> Unit = {},
     onNavigationIconClick: () -> Unit = {},
     onSaveActionClick: () -> Unit = {},
@@ -220,7 +203,7 @@ private fun GroupChannelEditContent(
     Scaffold(
         topBar = {
             GroupChannelEditTopBar(
-                isSaving = isSaving,
+                isBusy = isBusy,
                 onNavigationIconClick = onNavigationIconClick,
                 onSaveActionClick = onSaveActionClick,
             )
@@ -245,12 +228,12 @@ private fun GroupChannelEditContent(
                 onClick = onUploadPictureClick,
                 text = stringResource(R.string.stream_ui_channel_info_edit_upload_picture),
                 style = StreamButtonStyleDefaults.primaryGhost,
-                enabled = !isSaving,
+                enabled = !isBusy,
             )
             Spacer(modifier = Modifier.size(StreamTokens.spacing2xl))
             ChannelNameField(
                 value = channelName,
-                enabled = !isSaving,
+                enabled = !isBusy,
                 onValueChange = onChannelNameChange,
             )
         }
@@ -260,7 +243,7 @@ private fun GroupChannelEditContent(
 @Composable
 @OptIn(ExperimentalMaterial3Api::class)
 private fun GroupChannelEditTopBar(
-    isSaving: Boolean,
+    isBusy: Boolean,
     onNavigationIconClick: () -> Unit,
     onSaveActionClick: () -> Unit,
 ) {
@@ -276,7 +259,7 @@ private fun GroupChannelEditTopBar(
         },
         navigationIcon = { ChannelInfoNavigationIcon(onClick = onNavigationIconClick) },
         actions = {
-            if (isSaving) {
+            if (isBusy) {
                 LoadingIndicator(
                     modifier = Modifier
                         .padding(end = StreamTokens.spacingSm)
@@ -426,7 +409,6 @@ internal fun GroupChannelEditPlaceholder() {
     GroupChannelEditContent(
         channel = PreviewChannelData.channelWithImage,
         channelName = TextFieldValue(text = ""),
-        isSaving = false,
     )
 }
 
@@ -443,24 +425,23 @@ internal fun GroupChannelEditFilled() {
     GroupChannelEditContent(
         channel = PreviewChannelData.channelWithImage.copy(name = "Channel Name"),
         channelName = TextFieldValue(text = "Channel Name"),
-        isSaving = false,
     )
 }
 
 @Preview
 @Composable
-private fun GroupChannelEditSavingPreview() {
+private fun GroupChannelEditBusyPreview() {
     ChatTheme {
-        GroupChannelEditSaving()
+        GroupChannelEditBusy()
     }
 }
 
 @Composable
-internal fun GroupChannelEditSaving() {
+internal fun GroupChannelEditBusy() {
     GroupChannelEditContent(
         channel = PreviewChannelData.channelWithImage.copy(name = "Channel Name"),
         channelName = TextFieldValue(text = "Channel Name"),
-        isSaving = true,
+        isBusy = true,
     )
 }
 

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/GroupChannelEditUtils.kt

@@ -113,6 +113,7 @@ public fun GroupChannelInfoScreen(
     currentUser: User? = ChatClient.instance().getCurrentUser(),
     onNavigationIconClick: () -> Unit = {},
 ) {
+    val context = LocalContext.current
     val headerViewModel = viewModel<ChannelHeaderViewModel>(factory = viewModelFactory)
     val infoViewModel = viewModel<ChannelInfoViewModel>(factory = viewModelFactory)
     val headerState by headerViewModel.state.collectAsStateWithLifecycle()
@@ -136,7 +137,10 @@ public fun GroupChannelInfoScreen(
         FullscreenDialog(onDismissRequest = { showEditChannel = false }) {
             ViewModelStore {
                 val editViewModel = viewModel<GroupChannelEditViewModel>(
-                    factory = GroupChannelEditViewModelFactory(cid = channel.cid),
+                    factory = GroupChannelEditViewModelFactory(
+                        context = context,
+                        cid = channel.cid,
+                    ),
                 )
                 GroupChannelEditScreen(
                     viewModel = editViewModel,

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/GroupChannelInfoScreen.kt

@@ -0,0 +1,56 @@
+/*
+ * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved.
+ *
+ * Licensed under the Stream License;
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://github.com/GetStream/stream-chat-android/blob/main/LICENSE
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.getstream.chat.android.compose.viewmodel.channel
+
+import android.content.Context
+import android.net.Uri
+import io.getstream.chat.android.client.internal.file.StreamFileManager
+import java.io.File
+import java.util.UUID
+
+/**
+ * Copies a picked gallery or document [Uri] into app cache as a local image [File].
+ */
+internal fun interface GalleryImageCopier {
+    /**
+     * @param uri The content or file [Uri] to read.
+     * @return A file in app cache, or `null` if the [Uri] cannot be read or written.
+     */
+    fun copyToCache(uri: Uri): File?
+}
+
+/**
+ * [GalleryImageCopier] that reads the [Uri] via [android.content.ContentResolver] and writes a
+ * JPEG into timestamped cache using [StreamFileManager].
+ *
+ * @param context Used for [android.content.ContentResolver] and cache directory access.
+ * @param fileManager Writes the stream into cache.
+ */
+internal class ContentResolverImageCopier(
+    private val context: Context,
+    private val fileManager: StreamFileManager = StreamFileManager(),
+) : GalleryImageCopier {
+
+    override fun copyToCache(uri: Uri): File? {
+        val inputStream = context.contentResolver.openInputStream(uri) ?: return null
+        return fileManager.writeFileInTimestampedCache(
+            context = context,
+            fileName = "image_${UUID.randomUUID()}.jpg",
+            source = inputStream,
+        ).getOrNull()
+    }
+}