优化加入 HMCL 报错崩溃交流群#431
Conversation
|
还在更新吗？ |
这个我想等 #445 完成之后再改。 |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57da3d96f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var sec = parseInt(text.textContent, 10) || 10; | ||
| var timer = setInterval(function () { | ||
| text.textContent = --sec; | ||
| window.addEventListener("load", () => { |
There was a problem hiding this comment.
Because the rules dialog is only opened from the window load event, it waits for every image on the page (including the QR code below the link) to finish loading before showing the modal. On slow or stalled image loads, first-time visitors can see and click the QQ invite link for an extended period without ever seeing the required notice, which defeats the purpose of gating access; use DOMContentLoaded/ready instead so the modal appears as soon as the DOM is available.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
因为弹窗依赖 jquery 插件，所以需要等待 main.min.js 加载完毕后才能执行弹窗动作。
为缓解此问题我已为页面内容添加模糊效果并将文章中的图片调整为懒加载模式。
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
优化加入 HMCL 报错崩溃交流群
变更
https://patch-5-docs.hmcl.workers.dev/crash-support-group