Add test cases and fix for INTL0003 triggering on test methods with underscores

Co-authored-by: BenjaminMichaelis <[email protected]>

Author: Copilot

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/NamingMethodPascalTests.cs

@@ -442,6 +442,99 @@ void IInterface.foo() { }
             VerifyCSharpDiagnostic(test, expected1, expected2);
         }
 
+        [TestMethod]
+        [Description("Test method with underscores should not trigger INTL0003")]
+        public void TestMethodWithUnderscores_MSTest_NoDiagnosticInformationReturned()
+        {
+            string test = @"
+    using System;
+    using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+    namespace ConsoleApplication1
+    {
+        [TestClass]
+        public class TypeName
+        {   
+            [TestMethod]
+            public void FooThing_IsFooThing_HasFooThing() 
+            {
+                Assert.IsTrue(true);
+            } 
+        }
+    }";
+
+            VerifyCSharpDiagnostic(test);
+        }
+
+        [TestMethod]
+        [Description("Test method with underscores should not trigger INTL0003 - xUnit Fact")]
+        public void TestMethodWithUnderscores_XunitFact_NoDiagnosticInformationReturned()
+        {
+            string test = @"
+    using System;
+    using Xunit;
+
+    namespace ConsoleApplication1
+    {
+        public class TypeName
+        {   
+            [Fact]
+            public void FooThing_IsFooThing_HasFooThing() 
+            {
+                Assert.True(true);
+            } 
+        }
+    }";
+
+            VerifyCSharpDiagnostic(test);
+        }
+
+        [TestMethod]
+        [Description("Test method with underscores should not trigger INTL0003 - xUnit Theory")]
+        public void TestMethodWithUnderscores_XunitTheory_NoDiagnosticInformationReturned()
+        {
+            string test = @"
+    using System;
+    using Xunit;
+
+    namespace ConsoleApplication1
+    {
+        public class TypeName
+        {   
+            [Theory]
+            public void FooThing_IsFooThing_HasFooThing() 
+            {
+                Assert.True(true);
+            } 
+        }
+    }";
+
+            VerifyCSharpDiagnostic(test);
+        }
+
+        [TestMethod]
+        [Description("Test method with underscores should not trigger INTL0003 - NUnit Test")]
+        public void TestMethodWithUnderscores_NUnitTest_NoDiagnosticInformationReturned()
+        {
+            string test = @"
+    using System;
+    using NUnit.Framework;
+
+    namespace ConsoleApplication1
+    {
+        public class TypeName
+        {   
+            [Test]
+            public void FooThing_IsFooThing_HasFooThing() 
+            {
+                Assert.That(true, Is.True);
+            } 
+        }
+    }";
+
+            VerifyCSharpDiagnostic(test);
+        }
+
 
         protected override CodeFixProvider GetCSharpCodeFixProvider()
         {

IntelliTect.Analyzer/IntelliTect.Analyzer/Analyzers/NamingMethodPascal.cs

@@ -94,9 +94,39 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)
                 return;
             }
 
+            // Skip test methods - they commonly use underscores for readability (e.g., "Method_Scenario_ExpectedResult")
+            if (IsTestMethod(namedTypeSymbol))
+            {
+                return;
+            }
+
             Diagnostic diagnostic = Diagnostic.Create(_Rule, namedTypeSymbol.Locations[0], name);
 
             context.ReportDiagnostic(diagnostic);
         }
+
+        private static bool IsTestMethod(IMethodSymbol methodSymbol)
+        {
+            // Common test framework attributes
+            string[] testAttributeNames = 
+            [
+                "TestMethod",      // MSTest
+                "TestMethodAttribute",
+                "Fact",            // xUnit
+                "FactAttribute",
+                "Theory",          // xUnit
+                "TheoryAttribute",
+                "Test",            // NUnit
+                "TestAttribute",
+                "TestCase",        // NUnit
+                "TestCaseAttribute",
+                "TestCaseSource",  // NUnit
+                "TestCaseSourceAttribute"
+            ];
+
+            ImmutableArray<AttributeData> attributes = methodSymbol.GetAttributes();
+            return attributes.Any(attribute =>
+                testAttributeNames.Contains(attribute.AttributeClass?.Name));
+        }
     }
 }