Improve null handling clarity in IsTestMethod

Copilot · BenjaminMichaelis · BenjaminMichaelis · commit 4cf7f4b6af45 · 2026-03-10T14:33:55.000-07:00
Co-authored-by: BenjaminMichaelis &lt;22186029+BenjaminMichaelis@users.noreply.github.com&gt;
diff --git a/IntelliTect.Analyzer/IntelliTect.Analyzer/Analyzers/NamingMethodPascal.cs b/IntelliTect.Analyzer/IntelliTect.Analyzer/Analyzers/NamingMethodPascal.cs
@@ -126,7 +126,7 @@ private static bool IsTestMethod(IMethodSymbol methodSymbol)
 
             ImmutableArray<AttributeData> attributes = methodSymbol.GetAttributes();
             return attributes.Any(attribute =>
-                testAttributeNames.Contains(attribute.AttributeClass?.Name));
+                attribute.AttributeClass?.Name is string name && testAttributeNames.Contains(name));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ private static bool IsTestMethod(IMethodSymbol methodSymbol)`
`126`	`126`
`127`	`127`	`ImmutableArray<AttributeData> attributes = methodSymbol.GetAttributes();`
`128`	`128`	`return attributes.Any(attribute =>`
`129`		`- testAttributeNames.Contains(attribute.AttributeClass?.Name));`
	`129`	`+ attribute.AttributeClass?.Name is string name && testAttributeNames.Contains(name));`
`130`	`130`	`}`
`131`	`131`	`}`
`132`	`132`	`}`