Convert contents() to read()

Author: staticfloat

src/Abstract/Section.jl

@@ -6,7 +6,7 @@ export Sections,
 
 # Export Section API
 export Section,
-       deref, contents, section_name, section_size, section_offset,
+       deref, section_name, section_size, section_offset,
        section_address
 
 # Export Datatypes
@@ -136,7 +136,7 @@ subclasses must implement marked in emphasis:
   - deref()
 
 ### IO-like operations:
-  - contents()
+  - read()
 
 ### Format-specific properties:
   - *section_name()*
@@ -152,18 +152,17 @@ abstract type Section{H<:ObjectHandle} end
 deref(section::Section) = section
 
 """
-    contents(oh::ObjectHandle, section::Section)
+    read(oh::ObjectHandle, section::Section)
 
 Read the contents of the section referred to by `section` from the given
 `ObjectHandle`, returning a `Vector{UInt8}`.
 """
-function contents(oh::H, section::Section{H}) where {H<:ObjectHandle}
+function read(oh::H, section::Section{H}) where {H<:ObjectHandle}
     # Seek to the section's location, then read it in!
     seek(oh, section_offset(section))
-    return read(oh, size(section))
+    return read(oh, section_size(section))
 end
 
-
 """
     section_name(section::Section)
 

src/COFF/COFF.jl

@@ -13,7 +13,7 @@ import ObjectFile: DynamicLink, DynamicLinks, RPath, ObjectHandle, Section, Sect
                    format_string, section_header_offset, section_header_size, section_header_type,
                    segment_header_offset, segment_header_size, segment_header_type, startaddr,
                    symtab_entry_offset, symtab_entry_size, symtab_entry_type, find_libraries,
-                   findfirst, deref, contents, section_name, section_size,
+                   findfirst, deref, section_name, section_size,
                    section_offset, section_address, section_number, segment_name, segment_offset,
                    segment_file_size, segment_memory_size, segment_address, strtab_lookup,
                    symbol_name, symbol_value, isundef, isglobal, islocal, isweak, symbol_number

src/ELF/ELF.jl

@@ -13,7 +13,7 @@ import ObjectFile: DynamicLink, DynamicLinks, RPath, ObjectHandle, Section, Sect
                    format_string, section_header_offset, section_header_size, section_header_type,
                    segment_header_offset, segment_header_size, segment_header_type, startaddr,
                    symtab_entry_offset, symtab_entry_size, symtab_entry_type, find_libraries,
-                   findfirst, deref, contents, section_name, section_size,
+                   findfirst, deref, section_name, section_size,
                    section_offset, section_address, section_number, segment_name, segment_offset,
                    segment_file_size, segment_memory_size, segment_address, strtab_lookup,
                    symbol_name, symbol_value, isundef, isglobal, islocal, isweak, symbol_number
@@ -35,4 +35,4 @@ include("ELFDynamicLink.jl")
 #include("ELFRelocation.jl")
 #include("ELFDebug.jl")
 
-end # module ELF
+end # module ELF

src/MachO/MachO.jl

@@ -13,7 +13,7 @@ import ObjectFile: DynamicLink, DynamicLinks, RPath, ObjectHandle, Section, Sect
                    format_string, section_header_offset, section_header_size, section_header_type,
                    segment_header_offset, segment_header_size, segment_header_type, startaddr,
                    symtab_entry_offset, symtab_entry_size, symtab_entry_type, find_libraries,
-                   findfirst, deref, contents, section_name, section_size,
+                   findfirst, deref, section_name, section_size,
                    section_offset, section_address, section_number, segment_name, segment_offset,
                    segment_file_size, segment_memory_size, segment_address, strtab_lookup,
                    symbol_name, symbol_value, isundef, isglobal, islocal, isweak, symbol_number
@@ -35,4 +35,4 @@ include("MachOSymbol.jl")
 include("MachOFat.jl")
 
 
-end # module MachO
+end # module MachO