Conversation
Plus minor Makefile fix for a file whose name changed
Add boilerplate metafiles, asciidoctor config files, scripts, etc. based on Vulkan.
…r-chapter for Antora
latexmath macros, and one excess trailing table cell separator that caused an error.
Remove latexmath-like attribute shorthand from inline (already in attribs.adoc) Remove extra top-level headings that only appeared in PDF Modify anchor names that were invalid XML IDs
{align*} environments around multiple-line expressions in latexmath
blocks.
Use asciidoc attributes instead of HTML entities for special symbols,
which works for both HTML and PDF builds.
Remove some a2xhtml conditionals that are irrelevant, replace some
others (which may be irrelevant) with backend-html5 conditionals.
Use modern quote style everywhere.
Remove lunr module dependency, which is not needed in this repo.
Contributor
Author
|
One more comment - most of the math errors with the PDF build were due to latexmath blocks where there were multiline expressions (line ending in \ followed by another line) but no surrounding {align*} environment. With that added they stopped causing errors. I don't know if those were actual LaTeX math errors that just happened to work in the older math path, or problems in the new math path. Also, there were some places where \ needed to be added so multiple unrelated expressions did not get rendered on the same line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asciidoc.py is long obsolete and this gets on a path to incorporate the DF spec into Antora builds and use the current asciidoctor. The changes were pretty extensive and include markup conversions to modern asciidoc syntax, toolchain conversions from the old asciidoc style and converter paths, filename changes (.txt->.adoc) in anticipation of use in Antora, incorporation of repository boilerplate (REUSE etc.) common to many Khronos repos, and more.
The spec build works for both HTML and PDF targets, but there are many instances of a few formatting issues, mostly:
Finally, this is not up to date with the default branch. I did most of this work several years and just tweaked the branch tonight to be able to build PDF successfully, so the 1.4 changes are not included. That's a big delta because there were many changes in the formatting while 1.4 also did significant changes. @fluppeteer we should discuss offline if you try this out and want to proceed down this path. While you can still do a meaningful 'git diff' against main, it is enormous and conflict resolution will take considerable effort - I had originally hoped to get this in before major updates to the default branch occurred.
To build if you do not have the Vulkan spec toolchain already installed: