Skip to content

Commit 276b1a8

Browse files
committed
fix: SDK stuck when login with restricted external ID
1 parent a827295 commit 276b1a8

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/LoginUserOperationExecutor.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,8 @@ internal class LoginUserOperationExecutor(
237237
ExecutionResponse(ExecutionResult.FAIL_RETRY, retryAfterSeconds = ex.retryAfterSeconds)
238238
NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
239239
ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED, retryAfterSeconds = ex.retryAfterSeconds)
240+
NetworkUtils.ResponseStatusType.INVALID ->
241+
ExecutionResponse(ExecutionResult.FAIL_NORETRY)
240242
else ->
241243
ExecutionResponse(ExecutionResult.FAIL_PAUSE_OPREPO)
242244
}

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/user/internal/operations/LoginUserOperationExecutorTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class LoginUserOperationExecutorTests : FunSpec({
159159
val response = loginUserOperationExecutor.execute(operations)
160160

161161
// Then
162-
response.result shouldBe ExecutionResult.FAIL_PAUSE_OPREPO
162+
response.result shouldBe ExecutionResult.FAIL_NORETRY
163163
coVerify(exactly = 1) { mockUserBackendService.createUser(appId, mapOf(), any(), any()) }
164164
}
165165

0 commit comments

Comments
 (0)