Fix "against Enemies within 2m" mods not applying unless distance was exactly 2m#1949
Merged
LocalIdentity merged 3 commits intoMay 24, 2026
Merged
Conversation
Changing this logic broke the previous handling of these poison mods
LocalIdentity
changed the title
LocalIdentity
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
MultiplierThreshold with "upper=true" was applied only if value exact match threshold, while it should use threshould as upper limit
I have experienced this with mod "Projectiles have 40% increased Critical Damage Bonus against Enemies within 2m" that should apply whenever the distance is <= 20 units, but was applied only when distance is exactly 20units
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/3rOxLc4Ge0WJ
Before screenshot:
After screenshot:
MultiplierThreshold with "upper=true" applies whenever mult <= threshold