feat(voip): call waiting, busy detection, and videoconf blocking (#7077)

Author: diegolmello

android/app/build.gradle

@@ -153,6 +153,8 @@ dependencies {
 
     // For SecureKeystore (EncryptedSharedPreferences)
     implementation 'androidx.security:security-crypto:1.1.0'
+
+    testImplementation 'junit:junit:4.13.2'
 }
 
 apply plugin: 'com.google.gms.google-services'

android/app/src/main/java/chat/rocket/reactnative/voip/VoipIncomingCallDispatch.kt

@@ -0,0 +1,25 @@
+package chat.rocket.reactnative.voip
+
+/**
+ * Pure routing for an incoming VoIP FCM push after [VoipPayload.isVoipIncomingCall] is true.
+ * Stale (invalid or expired lifetime) pushes must not reach busy vs show branching.
+ */
+internal enum class VoipIncomingPushAction {
+    STALE,
+    REJECT_BUSY,
+    SHOW_INCOMING
+}
+
+internal fun decideIncomingVoipPushAction(
+    isValidForIncomingHandling: Boolean,
+    hasActiveCall: Boolean
+): VoipIncomingPushAction {
+    if (!isValidForIncomingHandling) {
+        return VoipIncomingPushAction.STALE
+    }
+    return if (hasActiveCall) {
+        VoipIncomingPushAction.REJECT_BUSY
+    } else {
+        VoipIncomingPushAction.SHOW_INCOMING
+    }
+}

android/app/src/main/java/chat/rocket/reactnative/voip/VoipNotification.kt

@@ -0,0 +1,50 @@
+package chat.rocket.reactnative.voip
+
+/**
+ * Per-call DDP client slots: each [callId] maps to at most one [DDPClient] in production.
+ * Isolates teardown so a busy-call reject (call B) does not disconnect call A's listener.
+ */
+internal class VoipPerCallDdpRegistry<T : Any>(
+    private val releaseClient: (T) -> Unit
+) {
+    private val lock = Any()
+    private val clients = mutableMapOf<String, T>()
+    private val loggedInCallIds = mutableSetOf<String>()
+
+    fun clientFor(callId: String): T? = synchronized(lock) { clients[callId] }
+
+    fun isLoggedIn(callId: String): Boolean = synchronized(lock) { loggedInCallIds.contains(callId) }
+
+    fun putClient(callId: String, client: T) {
+        synchronized(lock) {
+            clients.remove(callId)?.let(releaseClient)
+            clients[callId] = client
+            loggedInCallIds.remove(callId)
+        }
+    }
+
+    fun markLoggedIn(callId: String) {
+        synchronized(lock) {
+            loggedInCallIds.add(callId)
+        }
+    }
+
+    fun stopClient(callId: String) {
+        synchronized(lock) {
+            loggedInCallIds.remove(callId)
+            clients.remove(callId)?.let(releaseClient)
+        }
+    }
+
+    fun stopAllClients() {
+        synchronized(lock) {
+            loggedInCallIds.clear()
+            clients.values.forEach(releaseClient)
+            clients.clear()
+        }
+    }
+
+    fun clientCount(): Int = synchronized(lock) { clients.size }
+
+    fun clientIds(): Set<String> = synchronized(lock) { clients.keys.toSet() }
+}

android/app/src/main/java/chat/rocket/reactnative/voip/VoipPerCallDdpRegistry.kt

@@ -0,0 +1,39 @@
+package chat.rocket.reactnative.voip
+
+import org.junit.Assert.assertEquals
+import org.junit.Test
+
+class VoipIncomingCallDispatchTest {
+
+    @Test
+    fun `stale push with active call does not route to reject busy`() {
+        assertEquals(
+            VoipIncomingPushAction.STALE,
+            decideIncomingVoipPushAction(isValidForIncomingHandling = false, hasActiveCall = true)
+        )
+    }
+
+    @Test
+    fun `stale push without active call does not route to show incoming`() {
+        assertEquals(
+            VoipIncomingPushAction.STALE,
+            decideIncomingVoipPushAction(isValidForIncomingHandling = false, hasActiveCall = false)
+        )
+    }
+
+    @Test
+    fun `valid push with active call rejects busy`() {
+        assertEquals(
+            VoipIncomingPushAction.REJECT_BUSY,
+            decideIncomingVoipPushAction(isValidForIncomingHandling = true, hasActiveCall = true)
+        )
+    }
+
+    @Test
+    fun `valid push without active call shows incoming`() {
+        assertEquals(
+            VoipIncomingPushAction.SHOW_INCOMING,
+            decideIncomingVoipPushAction(isValidForIncomingHandling = true, hasActiveCall = false)
+        )
+    }
+}

android/app/src/test/java/chat/rocket/reactnative/voip/VoipIncomingCallDispatchTest.kt

@@ -0,0 +1,77 @@
+package chat.rocket.reactnative.voip
+
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class VoipPerCallDdpRegistryTest {
+
+    private fun registry(): Pair<MutableList<String>, VoipPerCallDdpRegistry<String>> {
+        val released = mutableListOf<String>()
+        return released to VoipPerCallDdpRegistry { released.add(it) }
+    }
+
+    @Test
+    fun `stopClient removes only the named callId`() {
+        val (released, reg) = registry()
+        reg.putClient("callA", "clientA")
+        reg.putClient("callB", "clientB")
+        reg.stopClient("callA")
+        assertEquals(listOf("clientA"), released)
+        assertEquals(setOf("callB"), reg.clientIds())
+        assertEquals("clientB", reg.clientFor("callB"))
+        assertNull(reg.clientFor("callA"))
+    }
+
+    @Test
+    fun `stopAllClients disconnects every entry`() {
+        val (released, reg) = registry()
+        reg.putClient("callA", "clientA")
+        reg.putClient("callB", "clientB")
+        reg.stopAllClients()
+        assertEquals(2, released.size)
+        assertTrue(released.containsAll(listOf("clientA", "clientB")))
+        assertEquals(0, reg.clientCount())
+        assertTrue(reg.clientIds().isEmpty())
+    }
+
+    @Test
+    fun `starting a second listener for another callId does not release the first`() {
+        val (released, reg) = registry()
+        reg.putClient("callA", "clientA")
+        reg.putClient("callB", "clientB")
+        assertTrue(released.isEmpty())
+        assertEquals(setOf("callA", "callB"), reg.clientIds())
+    }
+
+    @Test
+    fun `putClient for the same callId releases the previous client`() {
+        val (released, reg) = registry()
+        reg.putClient("callA", "first")
+        reg.putClient("callA", "second")
+        assertEquals(listOf("first"), released)
+        assertEquals("second", reg.clientFor("callA"))
+    }
+
+    @Test
+    fun `loggedIn state is per callId`() {
+        val (_, reg) = registry()
+        reg.putClient("callA", "a")
+        reg.putClient("callB", "b")
+        assertFalse(reg.isLoggedIn("callA"))
+        reg.markLoggedIn("callA")
+        assertTrue(reg.isLoggedIn("callA"))
+        assertFalse(reg.isLoggedIn("callB"))
+    }
+
+    @Test
+    fun `stopClient clears loggedIn for that callId`() {
+        val (_, reg) = registry()
+        reg.putClient("callA", "a")
+        reg.markLoggedIn("callA")
+        reg.stopClient("callA")
+        assertFalse(reg.isLoggedIn("callA"))
+    }
+}

android/app/src/test/java/chat/rocket/reactnative/voip/VoipPerCallDdpRegistryTest.kt

@@ -425,6 +425,8 @@
   "Pause": "توقف مؤقت",
   "Permalink_copied_to_clipboard": "تم نسخ الرابط الثابت إلى الحافظة!",
   "Phone": "الهاتف",
+  "Phone_state_permission_message": "يتيح ذلك لـ Rocket.Chat معرفة ما إذا كنت في مكالمة هاتفية أو VoIP حاليًا كي تُعالج المكالمات الواردة بشكل صحيح.",
+  "Phone_state_permission_title": "السماح بالوصول إلى حالة الهاتف",
   "Pin": "ثبت",
   "Pinned": "مثبت",
   "Play": "لعب",

app/i18n/locales/ar.json

@@ -595,6 +595,8 @@
   "Permalink_copied_to_clipboard": "পারমালিঙ্ক ক্লিপবোর্ডে কপি করা হয়েছে!",
   "Person_or_channel": "ব্যক্তি বা চ্যানেল",
   "Phone": "ফোন",
+  "Phone_state_permission_message": "এটি Rocket.Chat-কে আপনি ইতিমধ্যে কোনও ফোন বা VoIP কলে আছেন কিনা তা শনাক্ত করতে দেয়, যাতে ইনকামিং কলগুলি সঠিকভাবে পরিচালনা করা যায়।",
+  "Phone_state_permission_title": "ফোনের অবস্থা অ্যাক্সেসের অনুমতি দিন",
   "Pin": "পিন",
   "Pinned": "পিনকরা",
   "Pinned_a_message": "একটি বার্তা পিন করা হয়েছে:",

app/i18n/locales/bn-IN.json

@@ -634,6 +634,8 @@
   "Permalink_copied_to_clipboard": "Trvalý odkaz zkopírován do schránky!",
   "Person_or_channel": "Osoba nebo kanál",
   "Phone": "Telefon",
+  "Phone_state_permission_message": "Rocket.Chat tak může zjistit, zda již probíhá telefonní nebo hlasový (VoIP) hovor, a správně zpracovat příchozí hovory.",
+  "Phone_state_permission_title": "Povolit přístup ke stavu telefonu",
   "Pin": "Kolík",
   "Pinned": "Připnuto",
   "Pinned_a_message": "Připnuta zpráva:",

app/i18n/locales/cs.json

@@ -583,6 +583,8 @@
   "Pause": "Pause",
   "Permalink_copied_to_clipboard": "Permalink in die Zwischenablage kopiert!",
   "Phone": "Telefon",
+  "Phone_state_permission_message": "Damit kann Rocket.Chat erkennen, ob Sie bereits in einem Telefon- oder VoIP-Gespräch sind, damit eingehende Anrufe korrekt behandelt werden können.",
+  "Phone_state_permission_title": "Zugriff auf den Telefonstatus erlauben",
   "Pin": "Anheften",
   "Pinned": "Angeheftet",
   "Place_chat_on_hold": "Chat in die Warteschleife stellen",