Skip to content

Commit 32ce558

Browse files
committed
try remove reference to cefsharp.common
1 parent 7c2bead commit 32ce558

5 files changed

Lines changed: 32 additions & 6 deletions

File tree

CefSharp.OutOfProcess.BrowserProcess/CallbackProxies/DownloadHandlerProxy.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@ public DownloadHandlerProxy(IOutOfProcessHostRpc host)
1414

1515
public void BeforeDownloadCallback(BeforeDownloadCallbackDetails details)
1616
{
17-
Debugger.Launch();
18-
((IBeforeDownloadCallback)GetCallback(details.CallbackId)).Continue(details.DownloadPath, details.ShowDialog);
17+
((CefSharp.OutOfProcess.Interface.Callbacks.IBeforeDownloadCallback)GetCallback(details.CallbackId)).Continue(details.DownloadPath, details.ShowDialog);
1918
}
2019

2120
public void DownloadCallback(DownloadCallbackDetails details)
2221
{
23-
var cb = (IDownloadItemCallback)GetCallback(details.CallbackId);
22+
var cb = (CefSharp.OutOfProcess.Interface.Callbacks.IDownloadItemCallback)GetCallback(details.CallbackId);
2423
if (details.Cancel)
2524
{
2625
cb.Cancel();
@@ -40,12 +39,12 @@ bool IDownloadHandler.CanDownload(IWebBrowser chromiumWebBrowser, IBrowser brows
4039
return host.OnCanDownloadAsync(((OutOfProcessChromiumWebBrowser)chromiumWebBrowser).Id, url, requestMethod).Result;
4140
}
4241

43-
void IDownloadHandler.OnBeforeDownload(IWebBrowser chromiumWebBrowser, IBrowser browser, CefSharp.DownloadItem downloadItem, IBeforeDownloadCallback callback)
42+
void IDownloadHandler.OnBeforeDownload(IWebBrowser chromiumWebBrowser, IBrowser browser, CefSharp.DownloadItem downloadItem, CefSharp.IBeforeDownloadCallback callback)
4443
{
4544
host.OnBeforeDownload(((OutOfProcessChromiumWebBrowser)chromiumWebBrowser).Id, Convert(downloadItem), CreateCallback(callback));
4645
}
4746

48-
void IDownloadHandler.OnDownloadUpdated(IWebBrowser chromiumWebBrowser, IBrowser browser, CefSharp.DownloadItem downloadItem, IDownloadItemCallback callback)
47+
void IDownloadHandler.OnDownloadUpdated(IWebBrowser chromiumWebBrowser, IBrowser browser, CefSharp.DownloadItem downloadItem, CefSharp.IDownloadItemCallback callback)
4948
{
5049
host.OnDownloadUpdated(((OutOfProcessChromiumWebBrowser)chromiumWebBrowser).Id, Convert(downloadItem), CreateCallback(callback));
5150
}

CefSharp.OutOfProcess.Core/CefSharp.OutOfProcess.Core.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<PackageReference Include="PInvoke.Kernel32" Version="0.7.104" />
1111
<PackageReference Include="PInvoke.User32" Version="0.7.104" />
1212
<PackageReference Include="StreamJsonRpc" Version="2.11.35" />
13-
<PackageReference Include="CefSharp.Common" Version="109.1.110" />
1413

1514
<ProjectReference Include="..\CefSharp.OutOfProcess.Interface\CefSharp.OutOfProcess.Interface.csproj" />
1615
<ProjectReference Include="..\CefSharp.Dom\lib\PuppeteerSharp\CefSharp.Dom.OutOfProcess.csproj" />

CefSharp.OutOfProcess.Core/Handler/IDownloadHandler.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
namespace CefSharp.OutOfProcess.Handler
22
{
3+
using CefSharp.OutOfProcess.Interface.Callbacks;
4+
35
public interface IDownloadHandler
46
{
57
bool CanDownload(IChromiumWebBrowser chromiumWebBrowser, string url, string requestMethod);
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Text;
4+
5+
namespace CefSharp.OutOfProcess.Interface.Callbacks
6+
{
7+
public interface IBeforeDownloadCallback : IDisposable
8+
{
9+
bool IsDisposed { get; }
10+
void Continue(string downloadPath, bool showDialog);
11+
}
12+
}
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Text;
4+
5+
namespace CefSharp.OutOfProcess.Interface.Callbacks
6+
{
7+
public interface IDownloadItemCallback : IDisposable
8+
{
9+
bool IsDisposed { get; }
10+
void Cancel();
11+
void Pause();
12+
void Resume();
13+
}
14+
}

0 commit comments

Comments
 (0)