Commit 264d3d4
fix: address review feedback — 3 bugs
1. Warning body now says 'version' instead of 'release' on deploy-without-release path
2. Skip appInstallCount API call when prompt will be skipped (--force / --allow-updates+--allow-deletes)
3. Pass remoteApp.id (Management API app ID) instead of options.appId (API key) to appInstallCount
4. Add nullish coalesce for installCount in AppManagementClient (type safety)1 parent 8d91e15 commit 264d3d4
2 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
61 | 64 | | |
62 | | - | |
| 65 | + | |
63 | 66 | | |
64 | 67 | | |
65 | | - | |
| 68 | + | |
66 | 69 | | |
67 | 70 | | |
68 | 71 | | |
| |||
0 commit comments