improve code readability with append_env_var

Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>

Author: gudeh

flow/scripts/cts.tcl

@@ -46,11 +46,9 @@ set_placement_padding -global \
   -left $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT) \
   -right $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT)
 
-if { $::env(USE_NEGOTIATION) } {
-  set result [catch { log_cmd detailed_placement -use_negotiation } msg]
-} else {
-  set result [catch { log_cmd detailed_placement } msg]
-}
+set dpl_args {}
+append_env_var dpl_args USE_NEGOTIATION -use_negotiation 0
+set result [catch { log_cmd detailed_placement {*}$dpl_args } msg]
 if { $result != 0 } {
   save_progress 4_1_error
   error "Detailed placement failed in CTS: $msg"
@@ -74,11 +72,7 @@ if { !$::env(SKIP_CTS_REPAIR_TIMING) } {
     run_lec_test 4_rsz 4_before_rsz_lec.v 4_after_rsz_lec.v
   }
 
-  if { $::env(USE_NEGOTIATION) } {
-    set result [catch { log_cmd detailed_placement -use_negotiation } msg]
-  } else {
-    set result [catch { log_cmd detailed_placement } msg]
-  }
+  set result [catch { log_cmd detailed_placement {*}$dpl_args } msg]
   if { $result != 0 } {
     save_progress 4_1_error
     error "Detailed placement failed in CTS: $msg"

flow/scripts/detail_place.tcl

@@ -15,11 +15,9 @@ proc do_dpl { } {
   set_placement_padding -global \
     -left $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT) \
     -right $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT)
-  if { $::env(USE_NEGOTIATION) } {
-    log_cmd detailed_placement -use_negotiation {*}[env_var_or_empty DETAIL_PLACEMENT_ARGS]
-  } else {
-    log_cmd detailed_placement {*}[env_var_or_empty DETAIL_PLACEMENT_ARGS]
-  }
+  set dpl_args [env_var_or_empty DETAIL_PLACEMENT_ARGS]
+  append_env_var dpl_args USE_NEGOTIATION -use_negotiation 0
+  log_cmd detailed_placement {*}$dpl_args
 
   if { $::env(ENABLE_DPO) } {
     if { [env_var_exists_and_non_empty DPO_MAX_DISPLACEMENT] } {

flow/scripts/global_route.tcl

@@ -61,12 +61,10 @@ proc global_route_helper { } {
 
     # Running DPL to fix overlapped instances
     # Run to get modified net by DPL
+    set dpl_args {}
+    append_env_var dpl_args USE_NEGOTIATION -use_negotiation 0
     log_cmd global_route -start_incremental
-    if { $::env(USE_NEGOTIATION) } {
-      log_cmd detailed_placement -use_negotiation
-    } else {
-      log_cmd detailed_placement
-    }
+    log_cmd detailed_placement {*}$dpl_args
     # Route only the modified net by DPL
     log_cmd global_route -end_incremental {*}$res_aware \
       -congestion_report_file $::env(REPORTS_DIR)/congestion_post_repair_design.rpt
@@ -84,11 +82,7 @@ proc global_route_helper { } {
     # Running DPL to fix overlapped instances
     # Run to get modified net by DPL
     log_cmd global_route -start_incremental
-    if { $::env(USE_NEGOTIATION) } {
-      log_cmd detailed_placement -use_negotiation
-    } else {
-      log_cmd detailed_placement
-    }
+    log_cmd detailed_placement {*}$dpl_args
     check_placement -verbose
     # Route only the modified net by DPL
     log_cmd global_route -end_incremental {*}$res_aware \