Merge pull request #2432 from AckermannTM/relative-translation-keys-inside-blocks-resolve-to-partials-scope-instead-of-callers-scope

Relative translation keys inside blocks resolve to partials scope instead of callers scope

Author: joelhawksley

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 6
 
 ## main
 
+* Add test to document the current behavior for resolving relative translation keys within partial blocks. When rendering a partial, relative translation keys are resolved relative to the partial's own path rather than the caller’s path. This test ensures that this behavior remains consistent.
+
+    *Oussama Hilal*
+
 * Allow I18n calls in `render?`.
 
     *23tux*

test/sandbox/app/components/relative_translation_partial_block_component.html.erb

@@ -0,0 +1,3 @@
+<%= render "shared/partial" do %>
+  <%= t(".title") %>
+<% end %>

test/sandbox/app/components/relative_translation_partial_block_component.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class RelativeTranslationPartialBlockComponent < ViewComponent::Base
+end

test/sandbox/app/components/relative_translation_partial_parent_component.html.erb

@@ -0,0 +1,3 @@
+<%= render "shared/partial" do %>
+  <%= t(".title") %>
+<% end %>

test/sandbox/app/components/relative_translation_partial_parent_component.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class RelativeTranslationPartialParentComponent < ViewComponent::Base
+end

test/sandbox/app/views/shared/_partial.html.erb

@@ -0,0 +1 @@
+<%= yield %>

test/sandbox/config/locales/en.yml

@@ -25,6 +25,10 @@ en:
   my_component:
     message: "OH NO! (you shouldn't see me)"
 
+  shared:
+    partial:
+      title: Partial Title
+
   rendering_test:
     i18n_test_component:
       message: "I can be called in render?"

test/sandbox/test/components/relative_translation_partial_component_test.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class RelativeTranslationPartialBlockComponentTest < ViewComponent::TestCase
+  def test_relative_translation_in_partial_block
+    render_inline(RelativeTranslationPartialBlockComponent.new)
+
+    assert_text "Partial Title"
+  end
+end