Skip to content

Commit 788cb17

Browse files
authored
Unpin V8 (#5277)
* Do not compare reference values across executions Since we optimize assuming a closed world, optimizations can change the types and structure of GC data even in externally-visible ways. Because differences are expected, the fuzzer already did not compare reference-typed values from before and after optimizations when running with nominal typing. Update it to not compare these values under any type system. * Unpin V8 Our WasmGC output is no longer compatible with the previously pinned version and the issue that caused us to pin it in the first place has been resolved.
1 parent 2218b63 commit 788cb17

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

scripts/test/shared.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,9 +202,7 @@ def is_exe(fpath):
202202
NODEJS = os.getenv('NODE', which('node') or which('nodejs'))
203203
MOZJS = which('mozjs') or which('spidermonkey')
204204

205-
# TODO: Remove the specific v8 version once we implement structref and can run
206-
# on recent v8.
207-
V8 = which('v8-10.8.104') or which('v8') or which('d8')
205+
V8 = which('v8') or which('d8')
208206

209207
BINARYEN_INSTALL_DIR = os.path.dirname(options.binaryen_bin)
210208
WASM_OPT = [os.path.join(options.binaryen_bin, 'wasm-opt')]

0 commit comments

Comments
 (0)