-
Notifications
You must be signed in to change notification settings - Fork 174
Add adjustable makeup gain to DynamicsCompressorNode #2639
Copy link
Copy link
Open
Labels
Needs EditsDecision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/Priority: Eventually"nice to have". https://speced.github.io/spec-maintenance/about/"nice to have". https://speced.github.io/spec-maintenance/about/category: new featureSubstantive changes that add new functionality. https://www.w3.org/policies/process/#class-4Substantive changes that add new functionality. https://www.w3.org/policies/process/#class-4size: SSmall amount of work expected to resolve.Small amount of work expected to resolve.
Metadata
Metadata
Assignees
Labels
Needs EditsDecision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/Priority: Eventually"nice to have". https://speced.github.io/spec-maintenance/about/"nice to have". https://speced.github.io/spec-maintenance/about/category: new featureSubstantive changes that add new functionality. https://www.w3.org/policies/process/#class-4Substantive changes that add new functionality. https://www.w3.org/policies/process/#class-4size: SSmall amount of work expected to resolve.Small amount of work expected to resolve.
Describe the feature
The
DynamicsCompressorNodespecification currently has a fixed makeup gain derived from its other parameters: https://webaudio.github.io/web-audio-api/#computing-the-makeup-gainWhile automatic makeup gain is convenient in some use cases, some users of the Web Audio API want more control over the makeup gain. For instance see discussions here:
We could add a way for developers to control the makeup gain behavior.
Is there a prototype?
No.
Describe the feature in more detail
I propose allowing users to control makeup gain directly in
DynamicsCompressorNodeby adding the following:AudioParam,makeupGain, which represents the makeup gain value in dBDynamicsCompressorOptions,makeupGain, of type(float or MakeupGainOptions), whereMakeupGainOptionscan be anenumwith the value"automatic"makupGainis"automatic", the default, then the current behavior in the spec is usedmakeupGainis afloat, then that is the fixed makeup gain in dB (with 0 meaning no makeup gain)I think the basic idea of the above would work well, but we can also change the details or discuss alternative approaches.