Merge pull request #1073 from WebFuzzing/jdk-add-opens-for-jar

trying add-opens in jar

Author: arcuri82

core/pom.xml

@@ -328,6 +328,10 @@
                                     <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                                     <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
                                 </manifest>
+                                <manifestEntries>
+                                    <!-- needs to be kept in sync with JdkIssue -->
+                                    <Add-Opens>java.base/java.net java.base/java.util</Add-Opens>
+                                </manifestEntries>
                             </archive>
                             <finalName>evomaster</finalName>
                             <appendAssemblyId>false</appendAssemblyId>

core/src/main/kotlin/org/evomaster/core/JdkIssue.kt

@@ -22,15 +22,17 @@ object JdkIssue {
             return true
         }catch (e: Exception){
 
-            //This needs to be kept in sync with makeExecutable.sh
+            //This needs to be kept in sync with core/pom.xml -> maven-assembly-plugin
             val command = "--add-opens java.base/java.net=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED"
 
             LoggingUtil.getInfoLogger().error(inRed("It looks like you are running EvoMaster with JDK 17+," +
                     " but did not setup '--add-opens'." +
                     " Unfortunately, Java has broken a lot of backward compatibility in its recent versions." +
                     " You should use the EvoMaster OS installers (e.g., .msi and .dmg files)." +
-                    " If you want to use the JAR file directly, you need to either upgrade to JDK 8 or 11, or" +
-                    " setup --add-opens JVM option manually on the command-line" +
+                    " If you use the JAR file directly," +
+                    " --add-opens are now set directly in the manifest file." +
+                    " But this is not the case if you run EvoMaster directly from inside an IDE." +
+                    " You would need to set JVM options manually in the IDE" +
                     "  (or in the JDK_JAVA_OPTIONS environment variable):\n") +
                     inBlue("$command"))
 

makeExecutable.sh

@@ -38,6 +38,5 @@ COPYRIGHT="Copyright 2016-$YEAR EvoMaster Team"
 VENDOR="EvoMaster Team"
 
 $JPACKAGE --main-jar $JAR --input $BUILD --dest $RELEASE --name evomaster \
-  --copyright "$COPYRIGHT" --license-file ./LICENSE --vendor "$VENDOR" --app-version $VERSION $OS \
-  --java-options "--add-opens java.base/java.net=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED"
-# needs to be kept in sync with JdkIssue
+  --copyright "$COPYRIGHT" --license-file ./LICENSE --vendor "$VENDOR" --app-version $VERSION $OS
+

release_notes.md

@@ -3,8 +3,9 @@
 Under development in `master` branch.
 
 ### New Features
+- when running JAR file with JDK 17+, no longer need to manually specify --add-opens commands
 - schema validation for OpenAPI schemas, with summary of issues printed in the console logs
-- Generated tests that detect faults have now comments highlighting those faults. 
+- generated tests that detect faults have now comments highlighting those faults. 
 
 ### Bug Fixes
 - fixed release of JAR requiring JDK 21 by mistake