Skip to content

Commit dc2d70b

Browse files
committed
Faster Weakness Lookup
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent b06f85a commit dc2d70b

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

vulnerabilities/models.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@
5757
from vulnerabilities.utils import normalize_purl
5858
from vulnerabilities.utils import purl_to_dict
5959
from vulnerablecode import __version__ as VULNERABLECODE_VERSION
60-
from cwe2.weakness import Weakness as DBWeakness
61-
from cwe2.mappings import xml_database_path
62-
import xml.etree.ElementTree as ET
6360

6461
logger = logging.getLogger(__name__)
6562

@@ -473,6 +470,7 @@ def get_severity_vectors_and_values(self):
473470

474471
return severity_vectors, severity_values
475472

473+
476474
def get_cwes(self):
477475
"""Yield CWE Weakness objects"""
478476
for cwe_category in self.cwe_files:
@@ -485,7 +483,16 @@ def get_cwes(self):
485483
for tag_num in [1, 2]: # Categories , Views
486484
tag = root[tag_num]
487485
for child in tag:
488-
yield DBWeakness(*[child.attrib["ID"], child.attrib.get("Name"),None,child.attrib.get("Status"),child[0].text])
486+
yield DBWeakness(
487+
*[
488+
child.attrib["ID"],
489+
child.attrib.get("Name"),
490+
None,
491+
child.attrib.get("Status"),
492+
child[0].text,
493+
]
494+
)
495+
489496

490497
Database.get_cwes = get_cwes
491498

vulnerabilities/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ def get_context_data(self, **kwargs):
224224
NotImplementedError,
225225
):
226226
logging.error(f"CVSSMalformedError for {severity.scoring_elements}")
227-
228-
epss_severity = vulnerability.severities.filter(scoring_system='epss').first()
227+
228+
epss_severity = vulnerability.severities.filter(scoring_system="epss").first()
229229
epss_data = None
230230
if epss_severity:
231231
epss_data = {

0 commit comments

Comments
 (0)