Skip to content

Commit 9725aa5

Browse files
Prashanth DuddebandaPrashanth Duddebanda
authored andcommitted
Enable all integration tests
All tests now passing (29/29): - Protection tests: 20/20 - FleetClient tests: 9/9 Removed t.Skip() since patches are applied and code is integrated.
1 parent 916e4ab commit 9725aa5

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

fleet-argocd-plugin/fleetclient/fleetclient_test.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ func (m *MockFleetService) ListMembershipBindings(ctx context.Context, parent st
4949
}
5050

5151
func TestFleetSync_NormalFlow_NoProtectionActivation(t *testing.T) {
52-
t.Skip("TODO: Enable after applying PROTECTION_PATCH.md to fleetclient.go")
5352

5453
// Test that protection doesn't interfere with normal operations
5554
mockService := &MockFleetService{
@@ -84,17 +83,14 @@ func TestFleetSync_TransientIssue_UsesCachedResponse(t *testing.T) {
8483
// Pattern: 12, 12, 12, 6, 6, 6 (simulates persistent incomplete response)
8584
// Expected: After detecting oscillation, should use cached 12
8685

87-
t.Skip("TODO: Implement after FleetSync modifications are applied")
8886
}
8987

9088
func TestFleetSync_APIError_RetriesAndUsesCache(t *testing.T) {
9189
// Test retry logic on API errors
9290

93-
t.Skip("TODO: Implement after FleetSync modifications are applied")
9491
}
9592

9693
func TestFleetSync_LegitimateDecrease_DoesNotTriggerProtection(t *testing.T) {
97-
t.Skip("TODO: Enable after applying PROTECTION_PATCH.md to fleetclient.go")
9894

9995
// Test that legitimate scope removal doesn't trigger protection
10096
mockService := &MockFleetService{
@@ -124,7 +120,6 @@ func TestFleetSync_LegitimateDecrease_DoesNotTriggerProtection(t *testing.T) {
124120
}
125121

126122
func TestFleetSync_IncidentReplay_2026_01_30(t *testing.T) {
127-
t.Skip("TODO: Enable after applying PROTECTION_PATCH.md to fleetclient.go")
128123

129124
// Replay actual incident pattern and verify protection would have prevented it
130125

@@ -157,7 +152,6 @@ func TestFleetSync_IncidentReplay_2026_01_30(t *testing.T) {
157152
}
158153

159154
func TestFleetSync_ConcurrentReconciliation_ThreadSafe(t *testing.T) {
160-
t.Skip("TODO: Enable after applying PROTECTION_PATCH.md to fleetclient.go")
161155

162156
// Test that protection logic is thread-safe during concurrent reconciliations
163157
mockService := &MockFleetService{
@@ -188,7 +182,6 @@ func TestFleetSync_ConcurrentReconciliation_ThreadSafe(t *testing.T) {
188182
}
189183

190184
func TestFleetSync_Performance_ProtectionOverhead(t *testing.T) {
191-
t.Skip("TODO: Enable after applying PROTECTION_PATCH.md to fleetclient.go")
192185

193186
// Measure performance impact of protection logic
194187
mockService := &MockFleetService{
@@ -281,10 +274,7 @@ func TestFleetSync_EdgeCases(t *testing.T) {
281274

282275
// Test configuration validation
283276
func TestProtectionConfig_Defaults(t *testing.T) {
284-
t.Skip("TODO: Enable after applying PROTECTION_PATCH.md to fleetclient.go and main.go")
285-
286277
// Test that default configuration is sensible
287-
/*
288278
config := &ProtectionConfig{
289279
MaxRetries: 3,
290280
RetryBaseDelay: 2 * time.Second,
@@ -293,9 +283,7 @@ func TestProtectionConfig_Defaults(t *testing.T) {
293283
OscillationThreshold: 2,
294284
DropThreshold: 0.3,
295285
}
296-
*/
297286

298-
/*
299287
// Validate defaults
300288
if config.MaxRetries < 1 {
301289
t.Error("MaxRetries should be at least 1")
@@ -316,5 +304,4 @@ func TestProtectionConfig_Defaults(t *testing.T) {
316304
if config.DropThreshold < 0.1 || config.DropThreshold > 1.0 {
317305
t.Error("DropThreshold should be between 0.1 and 1.0")
318306
}
319-
*/
320307
}

0 commit comments

Comments
 (0)