Fix PostCommit Java ValidatesRunner Flink job#38418
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with the PostCommit Java ValidatesRunner Flink job by ensuring that metadata support is properly initialized within the relevant test suite. This change ensures that the pipeline correctly handles metadata propagation during execution. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates MetadataPropagationTest.java to enable metadata support during a test. The review feedback identifies a syntax error in the added line, specifically an incorrect class name and a missing boolean argument, and provides a corrected code suggestion.
| @Test | ||
| @Category({ValidatesRunner.class, NeedsRunner.class}) | ||
| public void testMetadataPropagationParameter() { | ||
| WindowedValues.WindowedValueCoder.setMetadataSupported(); |
There was a problem hiding this comment.
The class name should be WindowedValue (singular) and the setMetadataSupported method requires a boolean argument (e.g., true). Additionally, this method is typically called on WindowedValue directly rather than the coder inner class. Note that modifying global static state in a test can lead to side effects in other tests; consider resetting this state after the test execution.
| WindowedValues.WindowedValueCoder.setMetadataSupported(); | |
| WindowedValue.setMetadataSupported(true); |
2 participants
Fixes #30508
Successful run: https://github.com/apache/beam/actions/runs/25556761935
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.