diff --git a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy index 10aa127ed806..f980c7264de0 100644 --- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy +++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy @@ -1581,8 +1581,6 @@ class BeamModulePlugin implements Plugin { "StringCaseLocaleUsage", // DoFn methods are executed reflectively at pipeline runtime "UnusedMethod", - // Void is a valid element type of DoFn elements - "VoidUsed", ] disabledChecks.each { options.errorprone.errorproneArgs.add("-Xep:${it}:OFF") diff --git a/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java b/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java index 1797a0e40ac1..23205409f70a 100644 --- a/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java +++ b/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java @@ -40,6 +40,7 @@ /** Tests grouping with null values. */ public class GroupByWithNullValuesTest implements Serializable { + @SuppressWarnings("VoidUsed") @Test public void testGroupByWithNullValues() { FlinkPipelineOptions options = FlinkPipelineOptions.defaults(); diff --git a/runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java b/runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java index 8dda27e3a898..5f511a0c7d44 100644 --- a/runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java +++ b/runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java @@ -44,10 +44,9 @@ public void testEncodeDecode() { @Test public void testNullKey() { - Void key = null; VoidCoder coder = VoidCoder.of(); - ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(key, coder); + ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(null, coder); assertThat(FlinkKeyUtils.decodeKey(byteBuffer, coder), is(nullValue())); } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java index 8a273127b4fc..945f68ddc22a 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java @@ -914,7 +914,9 @@ public void testSideInputAnnotationFailedValidationMissing() { DoFn> fn = new DoFn>() { @ProcessElement - public void processElement(@SideInput(sideInputTag1) String tag1) {} + public void processElement(@SideInput(sideInputTag1) String tag1) { + ProcessContext c; + } }; thrown.expect(IllegalArgumentException.class); diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java index c674ce84eed7..b53dbfd4fa5d 100644 --- a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java +++ b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java @@ -2615,7 +2615,7 @@ public DataSource apply(Void input) { return instances.computeIfAbsent( config.config, ignored -> { - DataSource basicSource = config.apply(input); + DataSource basicSource = config.apply(null); DataSourceConnectionFactory connectionFactory = new DataSourceConnectionFactory(basicSource); @SuppressWarnings("nullness") // apache.commons.dbcp2 not annotated