Refactor from copilot code review

Author: nvazquez

engine/schema/src/main/java/com/cloud/host/dao/HostTagsDao.java

@@ -46,5 +46,8 @@ public interface HostTagsDao extends GenericDao<HostTagVO, Long> {
 
     List<HostTagVO> searchByIds(Long... hostTagIds);
 
+    /**
+     * List all host tags defined on hosts within a cluster
+     */
     List<String> listByClusterId(Long clusterId);
 }

engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java

@@ -23,6 +23,7 @@
 import org.apache.cloudstack.framework.config.ConfigKey;
 import org.apache.cloudstack.framework.config.Configurable;
 import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.commons.collections4.CollectionUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
@@ -79,7 +80,7 @@ public HostTagsDaoImpl() {
 
         tagSearch = createSearchBuilder(String.class);
         tagSearch.selectFields(tagSearch.entity().getTag());
-        tagSearch.and("idIN", tagSearch.entity().getId(), SearchCriteria.Op.IN);
+        tagSearch.and("hostIdIN", tagSearch.entity().getHostId(), SearchCriteria.Op.IN);
         tagSearch.done();
     }
 
@@ -248,8 +249,11 @@ public List<HostTagVO> searchByIds(Long... tagIds) {
     @Override
     public List<String> listByClusterId(Long clusterId) {
         List<Long> hostIds = hostDao.listIdsByClusterId(clusterId);
+        if (CollectionUtils.isEmpty(hostIds)) {
+            return new ArrayList<>();
+        }
         SearchCriteria<String> sc = tagSearch.create();
-        sc.setParameters("idIN", hostIds.toArray());
+        sc.setParameters("hostIdIN", hostIds.toArray());
         return customSearch(sc, null);
     }
 }

server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

@@ -4502,7 +4502,7 @@ protected void addVmCurrentClusterHostTags(VMInstanceVO vmInstance, List<String>
         }
         List<String> clusterTags = _hostTagDao.listByClusterId(host.getClusterId());
         if (CollectionUtils.isEmpty(clusterTags)) {
-            logger.warn("No host tags defined for hosts in the cluster " + host.getClusterId());
+            logger.debug("No host tags defined for hosts in the cluster " + host.getClusterId());
             return;
         }
         Set<String> existingTagsSet = new HashSet<>(hostTags);