address review comments

Author: kazuyukitanimura

spark/src/test/resources/sql-tests/expressions/math/tan.sql

@@ -22,11 +22,11 @@ statement
 CREATE TABLE test_tan(d double) USING parquet
 
 statement
-INSERT INTO test_tan VALUES (0.0), (0.7853981633974483), (-0.7853981633974483), (1.0), (NULL), (cast('NaN' as double)), (cast('Infinity' as double))
+INSERT INTO test_tan VALUES (0.0), (-0.0), (0.7853981633974483), (-0.7853981633974483), (1.0), (NULL), (cast('NaN' as double)), (cast('Infinity' as double))
 
 query tolerance=1e-6
 SELECT tan(d) FROM test_tan
 
 -- literal arguments
 query tolerance=1e-6
-SELECT tan(0.0), tan(0.7853981633974483), tan(NULL)
+SELECT tan(0.0), tan(-0.0), tan(0.7853981633974483), tan(NULL)

spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala

@@ -1345,41 +1345,39 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
 
   test("various math scalar functions") {
     val data = doubleValues.map(n => (n, n))
-    withSQLConf() {
-      withParquetTable(data, "tbl") {
-        // expressions with single arg
-        for (expr <- Seq(
-            "acos",
-            "asin",
-            "atan",
-            "cos",
-            "cosh",
-            "exp",
-            "ln",
-            "log10",
-            "log2",
-            "sin",
-            "sinh",
-            "sqrt",
-            "tan",
-            "tanh",
-            "cot")) {
-          val (_, cometPlan) =
-            checkSparkAnswerAndOperatorWithTol(sql(s"SELECT $expr(_1), $expr(_2) FROM tbl"))
-          val cometProjectExecs = collect(cometPlan) { case op: CometProjectExec =>
-            op
-          }
-          assert(cometProjectExecs.length == 1, expr)
-        }
-        // expressions with two args
-        for (expr <- Seq("pow")) {
-          val (_, cometPlan) =
-            checkSparkAnswerAndOperatorWithTol(sql(s"SELECT $expr(_1, _2) FROM tbl"))
-          val cometProjectExecs = collect(cometPlan) { case op: CometProjectExec =>
-            op
-          }
-          assert(cometProjectExecs.length == 1, expr)
-        }
+    withParquetTable(data, "tbl") {
+      // expressions with single arg
+      for (expr <- Seq(
+          "acos",
+          "asin",
+          "atan",
+          "cos",
+          "cosh",
+          "exp",
+          "ln",
+          "log10",
+          "log2",
+          "sin",
+          "sinh",
+          "sqrt",
+          "tan",
+          "tanh",
+          "cot")) {
+        val (_, cometPlan) =
+          checkSparkAnswerAndOperatorWithTol(sql(s"SELECT $expr(_1), $expr(_2) FROM tbl"))
+        val cometProjectExecs = collect(cometPlan) { case op: CometProjectExec =>
+          op
+        }
+        assert(cometProjectExecs.length == 1, expr)
+      }
+      // expressions with two args
+      for (expr <- Seq("pow")) {
+        val (_, cometPlan) =
+          checkSparkAnswerAndOperatorWithTol(sql(s"SELECT $expr(_1, _2) FROM tbl"))
+        val cometProjectExecs = collect(cometPlan) { case op: CometProjectExec =>
+          op
+        }
+        assert(cometProjectExecs.length == 1, expr)
       }
     }
   }