Skip to content

Commit 1e75615

Browse files
authored
HIVE-29519: Redundant perfLogger reset and queryStartTime update (#6386)
1 parent 931d4bb commit 1e75615

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

ql/src/java/org/apache/hadoop/hive/ql/Driver.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,6 @@ private void runInternal(String command, boolean alreadyCompiled) throws Command
170170

171171
if (!alreadyCompiled) {
172172
compileInternal(command, true);
173-
} else {
174-
driverContext.recordQueryStartTime();
175173
}
176174

177175
DriverUtils.checkInterrupted(driverState, driverContext, "at acquiring the lock.", null, null);
@@ -273,14 +271,12 @@ private void validateCurrentSnapshot() throws CommandProcessorException {
273271
driverContext.setRetrial(true);
274272

275273
compileInternal(context.getCmd(), true);
274+
driverContext.setRetrial(false);
276275

277276
if (driverContext.getPlan().hasAcidResourcesInQuery()) {
278277
driverTxnHandler.recordValidWriteIds();
279278
driverTxnHandler.setWriteIdForAcidFileSinks();
280279
}
281-
// Since we're reusing the compiled plan, we need to update its start time for current run
282-
driverContext.recordQueryStartTime();
283-
driverContext.setRetrial(false);
284280
}
285281
// Re-check snapshot only in case we had to release locks and open a new transaction,
286282
// otherwise exclusive locks should protect output tables/partitions in snapshot from concurrent writes.

ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,4 @@ public void setExplainPlan(String explainPlan) {
275275
public String getExplainPlan() {
276276
return explainPlan;
277277
}
278-
279-
public void recordQueryStartTime() {
280-
plan.setQueryStartTime(queryDisplay.getQueryStartTime());
281-
}
282278
}

0 commit comments

Comments
 (0)