Skip to content
This repository was archived by the owner on Aug 4, 2022. It is now read-only.

Commit 5d8189a

Browse files
committed
address pr comments
1 parent d081df9 commit 5d8189a

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

lang/cs/Org.Apache.REEF.IO.Tests/TestAzureBlockBlobFileSystemE2E.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ namespace Org.Apache.REEF.IO.Tests
3636
/// </summary>
3737
public sealed class TestAzureBlockBlobFileSystemE2E : IDisposable
3838
{
39-
private const string SkipMessage = "Fill in credentials before running test"; // Use null to run tests
39+
// Uncomment SkipMessage = null to run tests
40+
private const string SkipMessage = "Fill in credentials before running test";
41+
// private const string SkipMessage = null;
4042
private const string HelloFile = "hello";
4143
private IFileSystem _fileSystem;
4244
private CloudBlobClient _client;

lang/cs/Org.Apache.REEF.IO/FileSystem/AzureBlob/AzureCloudBlobClient.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ public BlobResultSegment ListBlobsSegmented(
8686
continuationToken,
8787
blobRequestOptions,
8888
operationContext);
89-
task.Wait();
9089
return task.Result;
9190
}
9291

lang/cs/Org.Apache.REEF.IO/FileSystem/Hadoop/HadoopFileSystem.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
using System;
1919
using System.Collections.Generic;
20-
using System.Globalization;
2120
using System.IO;
2221
using System.Linq;
2322
using System.Text.RegularExpressions;
@@ -156,11 +155,7 @@ public bool IsDirectory(Uri uri)
156155
{
157156
// TODO[JIRA REEF - 2039]: HadoopFileSystem .IsDirectory() check needs to work on linux machines.
158157
var stdOut = _commandRunner.Run("dfs -test -d " + uri + "& call echo %^errorlevel%").StdOut;
159-
if (stdOut.Any())
160-
{
161-
return "0".Equals(stdOut.First());
162-
}
163-
return false;
158+
return stdOut.Any() && stdOut.First() == "0";
164159
}
165160

166161
public void DeleteDirectory(Uri directoryUri)

0 commit comments

Comments
 (0)