Skip to content

Commit dc5671d

Browse files
tagatacholdenk
authored andcommitted
Fix a couple of typos in contributing.md
1. Match the imperative voice of other bullets in the "Contributing to JIRA maintenance" section. 2. "lower case latter" --> "lower case letter" Author: David Tagatac <dtag@amazon.com> Closes #679 from tagatac/contrib-typos.
1 parent bb8af61 commit dc5671d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

contributing.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ When resolving JIRAs, observe a few useful conventions:
125125
- In case several people contributed, prefer to assign to the more 'junior', non-committer contributor
126126
- For issues that can't be reproduced against master as reported, resolve as **Cannot Reproduce**
127127
- Fixed is reasonable too, if it's clear what other previous pull request resolved it. Link to it.
128-
- If the issue is the same as or a subset of another issue, resolved as **Duplicate**
128+
- If the issue is the same as or a subset of another issue, resolve as **Duplicate**
129129
- Make sure to link to the JIRA it duplicates
130130
- Prefer to resolve the issue that has less activity or discussion as the duplicate
131131
- If the issue seems clearly obsolete and applies to issues or components that have changed
@@ -479,7 +479,7 @@ lines can be up to 100 characters in length, not 79.
479479
- For R code, Apache Spark follows
480480
<a href="https://google.github.io/styleguide/Rguide.xml">Google's R Style Guide</a> with three exceptions:
481481
lines can be up to 100 characters in length, not 80, there is no limit on function name but it has a initial
482-
lower case latter and S4 objects/methods are allowed.
482+
lower case letter and S4 objects/methods are allowed.
483483
- For Java code, Apache Spark follows
484484
<a href="http://www.oracle.com/technetwork/java/codeconvtoc-136057.html">Oracle's Java code conventions</a> and
485485
Scala guidelines below. The latter is preferred.

site/contributing.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ <h2>Contributing to JIRA maintenance</h2>
278278
<li>Fixed is reasonable too, if it&#8217;s clear what other previous pull request resolved it. Link to it.</li>
279279
</ul>
280280
</li>
281-
<li>If the issue is the same as or a subset of another issue, resolved as <strong>Duplicate</strong>
281+
<li>If the issue is the same as or a subset of another issue, resolve as <strong>Duplicate</strong>
282282
<ul>
283283
<li>Make sure to link to the JIRA it duplicates</li>
284284
<li>Prefer to resolve the issue that has less activity or discussion as the duplicate</li>
@@ -692,7 +692,7 @@ <h2>Code style guide</h2>
692692
<li>For R code, Apache Spark follows
693693
<a href="https://google.github.io/styleguide/Rguide.xml">Google&#8217;s R Style Guide</a> with three exceptions:
694694
lines can be up to 100 characters in length, not 80, there is no limit on function name but it has a initial
695-
lower case latter and S4 objects/methods are allowed.</li>
695+
lower case letter and S4 objects/methods are allowed.</li>
696696
<li>For Java code, Apache Spark follows
697697
<a href="http://www.oracle.com/technetwork/java/codeconvtoc-136057.html">Oracle&#8217;s Java code conventions</a> and
698698
Scala guidelines below. The latter is preferred.</li>

0 commit comments

Comments
 (0)