Get rid of long constructors

Author: mwunderl

src/main/java/scorekeep/Move.java

@@ -21,53 +21,48 @@ public class Move {
   public Move() {
   }
 
-  public Move(String id, String session, String game, String user, String move) {
-    this.id = id;
-    this.session = session;
-    this.game = game;
-    this.user = user;
-    this.move = move;
-  }
-
   @DynamoDBHashKey(attributeName="id")
   public String getId() {
     return id;
   }
-  public void setId(String id){
+  public Move setId(String id){
     this.id = id;
+    return this;
   }
 
   @DynamoDBIndexHashKey(globalSecondaryIndexName="game-index",attributeName="game")
   public String getGame() {
     return game;
   }
-  public void setGame(String gameId){
+  public Move setGame(String gameId){
     this.game = gameId;
+    return this;
   }
 
   @DynamoDBAttribute(attributeName="session")  
   public String getSession() {
     return session;
   }
-  public void setSession(String sessionId) {
+  public Move setSession(String sessionId) {
     this.session = sessionId;
+    return this;
   }
 
   @DynamoDBAttribute(attributeName="user")  
   public String getUser() {
     return user;
   }
-  public void setUser(String userId) {
+  public Move setUser(String userId) {
     this.user = userId;
+    return this;
   }
 
   @DynamoDBAttribute(attributeName="move")  
   public String getMove() {
     return move;
   }
-  public void setMove(String moveId) {
+  public Move setMove(String moveId) {
     this.move = moveId;
+    return this;
   }
-
-
 }

src/main/java/scorekeep/MoveFactory.java

@@ -24,7 +24,11 @@ public MoveFactory(){
   public Move newMove(String sessionId, String gameId, String userId, String moveText) throws SessionNotFoundException, GameNotFoundException, StateNotFoundException, RulesException {
     String moveId = Identifiers.random();
     String stateId = Identifiers.random();
-    Move move = new Move(moveId, sessionId, gameId, userId, moveText);
+    Move move = new Move().setId(moveId)
+                          .setSession(sessionId)
+                          .setGame(gameId)
+                          .setUser(userId)
+                          .setMove(moveText);
     String newStateText = "";
     // load game state
     Game game = gameController.getGame(sessionId, gameId);

src/main/java/scorekeep/Rules.java

@@ -2,55 +2,79 @@
 
 public class Rules {
 
-  private final String id;
-  private final String name;
-  private final String[] categories;
-  private final Integer[] users;
-  private final Integer teams;
-  private final String[] phases;
-  private final String[] moves;
-  private final String initialState;
-
-  public Rules(String id, String name, String[] categories, Integer[] users, Integer teams, String[] phases, String[] moves, String initialState) {
-    this.id = id;
-    this.name = name;
-    this.categories = categories;
-    this.users = users;
-    this.teams = teams;
-    this.phases = phases;
-    this.moves = moves;
-    this.initialState = initialState;
-  }
+  private String id;
+  private String name;
+  private String[] categories;
+  private Integer[] users;
+  private Integer teams;
+  private String[] phases;
+  private String[] moves;
+  private String initialState;
+
+  public Rules() {
+  };
 
   public String getId() {
     return id;
   }
+  public Rules setId(String id){
+    this.id = id;
+    return this;
+  }
 
   public String getName() {
     return name;
   }
+  public Rules setName(String name){
+    this.name = name;
+    return this;
+  }
 
   public String[] getCategories() {
     return categories;
   }
+  public Rules setCategories(String[] categories){
+    this.categories = categories;
+    return this;
+  }
 
   public Integer[] getUsers() {
     return users;
   }
+  public Rules setUsers(Integer[] users){
+    this.users = users;
+    return this;
+  }
 
   public Integer getTeams() {
     return teams;
   }
+  public Rules setTeams(Integer teams){
+    this.teams = teams;
+    return this;
+  }
 
   public String[] getPhases() {
     return phases;
   }
+  public Rules setPhases(String[] phases){
+    this.phases = phases;
+    return this;
+  }
 
   public String[] getMoves() {
     return moves;
   }
+  public Rules setMoves(String[] moves){
+    this.moves = moves;
+    return this;
+  }
 
   public String getInitialState() {
     return initialState;
   }
+  public Rules setInitialState(String initialState){
+    this.initialState = initialState;
+    return this;
+  }
 }

src/main/java/scorekeep/TicTacToe.java

@@ -17,7 +17,14 @@ public static Rules getRules() {
     String[] phases = { "Move" };
     String[] moves = { "Roll" };
     String initialState = "X         ";
-    Rules tictactoe = new Rules(id, name, categories, users, teams, phases, moves, initialState);
+    Rules tictactoe = new Rules().setId(id)
+                                 .setName(name)
+                                 .setCategories(categories)
+                                 .setUsers(users)
+                                 .setTeams(teams)
+                                 .setPhases(phases)
+                                 .setMoves(moves)
+                                 .setInitialState(initialState);
     return tictactoe;
   }
   /* State is a string with one character that indicates the current turn