core/requestALB.go seem to be double escaping query string parameters

[choonkeat]

In

aws-lambda-go-api-proxy/core/requestALB.go

Lines 126 to 132 in 3f6c816

	for q, l := range req.MultiValueQueryStringParameters {
	for _, v := range l {
	if queryString != "" {
	queryString += "&"
	}
	queryString += url.QueryEscape(q) + "=" + url.QueryEscape(v)
	}

It would seem like the key and values in req.MultiValueQueryStringParameters are raw i.e. already query escaped

so it should be

- queryString += url.QueryEscape(q) + "=" + url.QueryEscape(v)
+ queryString += q + "=" + v

I'm not sure about QueryStringParameters

[choonkeat]

related #147

[choonkeat]

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html

If you enable multi-value headers, the load balancer uses both cookies sent by the client and sends you an event that includes headers using multiValueHeaders. For example:

"multiValueHeaders": {
    "cookie": ["name1=value1", "name2=value2"],
    ...
},

If the query parameters are URL-encoded, the load balancer does not decode them. You must decode them in your Lambda function.

[alecava41]

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html

If you enable multi-value headers, the load balancer uses both cookies sent by the client and sends you an event that includes headers using multiValueHeaders. For example:
"multiValueHeaders": {
"cookie": ["name1=value1", "name2=value2"],
...
},

If the query parameters are URL-encoded, the load balancer does not decode them. You must decode them in your Lambda function.

I don't get how the suggested solution could solve the problem, could you please elaborate further?