fix: check max attributes based on attributes count and not tags count

Author: Minishlink

src/BatchEventData.test.ts

@@ -0,0 +1,53 @@
+import { BatchEventData, Consts } from './BatchEventData';
+import * as Logger from './helpers/Logger';
+
+describe('BatchEventData', () => {
+  it(`handles less than or equal ${Consts.EventDataMaxTags} tags`, () => {
+    const batchEventData = new BatchEventData();
+    const spy = jest.spyOn(Logger, 'Log');
+
+    for (let i = 1; i <= Consts.EventDataMaxTags; i++) {
+      batchEventData.addTag(`tag ${i}`);
+    }
+
+    expect(spy).not.toHaveBeenCalled();
+  });
+  it(`handles less than or equal ${
+    Consts.EventDataMaxValues
+  } attributes`, () => {
+    const batchEventData = new BatchEventData();
+    const spy = jest.spyOn(Logger, 'Log');
+
+    for (let i = 1; i <= Consts.EventDataMaxValues; i++) {
+      batchEventData.put(`key_${i}`, 'value');
+    }
+
+    expect(spy).not.toHaveBeenCalled();
+  });
+  it(`skips other tags after the first ${Consts.EventDataMaxTags}`, () => {
+    const batchEventData = new BatchEventData();
+    const spy = jest.spyOn(Logger, 'Log');
+
+    for (let i = 1; i <= Consts.EventDataMaxTags; i++) {
+      batchEventData.addTag(`tag ${i}`);
+    }
+
+    batchEventData.addTag('too much');
+
+    expect(spy).toHaveBeenCalled();
+  });
+  it(`skips other attributes after the first ${
+    Consts.EventDataMaxValues
+  }`, () => {
+    const batchEventData = new BatchEventData();
+    const spy = jest.spyOn(Logger, 'Log');
+
+    for (let i = 1; i <= Consts.EventDataMaxValues; i++) {
+      batchEventData.put(`key_${i}`, 'value');
+    }
+
+    batchEventData.put('too_much', 'value');
+
+    expect(spy).toHaveBeenCalled();
+  });
+});

src/BatchEventData.ts

@@ -1,7 +1,7 @@
-import Log from './helpers/Logger';
+import { Log } from './helpers/Logger';
 import { isString, isNumber, isBoolean } from './helpers/TypeHelpers';
 
-const Consts = {
+export const Consts = {
   AttributeKeyRegexp: /^[a-zA-Z0-9_]{1,30}$/,
   EventDataMaxTags: 10,
   EventDataMaxValues: 10,
@@ -93,7 +93,7 @@ export class BatchEventData {
     key = key.toLowerCase();
 
     if (
-      Object.keys(this._tags).length >= Consts.EventDataMaxValues &&
+      Object.keys(this._attributes).length >= Consts.EventDataMaxValues &&
       !this._attributes.hasOwnProperty(key)
     ) {
       Log(

src/helpers/Logger.ts

@@ -1,10 +1,12 @@
 const DEBUG = false;
 
-export default function Log(debug: boolean, ...message: any[]) {
+export function Log(debug: boolean, ...message: any[]) {
   const args = ['[Batch]'].concat(Array.prototype.slice.call(arguments, 1));
   if (DEBUG && debug) {
     console.debug.apply(console, args);
   } else if (debug === false) {
     console.log.apply(console, args);
   }
 }
+
+export default Log;