For each mesh instance, only store the previous frame's transform, not the entire MeshInputUniform.#23892
Open
pcwalton wants to merge 1 commit into
Open
For each mesh instance, only store the previous frame's transform, not the entire MeshInputUniform.#23892pcwalton wants to merge 1 commit into
MeshInputUniform.#23892pcwalton wants to merge 1 commit into
Conversation
the entire `MeshInputUniform`. Currently, we copy the entire `MeshInputUniform`, which is 24 words, to the previous mesh instance buffer. This is wasteful, as we only ever use the transform for motion blur. This patch fixes the issue by introducing a new type, `PreviousMeshInputUniform`, that contains only the transform. Not only does this improve performance, but it will also simplify future work to sparsely update only the `MeshInputUniform` fields that changed. On `bevy_city --no-cpu-culling`, this commit reduces `write_previous_input_buffers` from a median time of 240.1 μs to 65.33 μs, a 3.68× speedup.
pcwalton
added
C-Performance
pcwalton
added
the
S-Needs-Review
kfc35
added
D-Straightforward
Contributor
|
just a note that you have to resolve some merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we copy the entire
MeshInputUniform, which is 24 words, to the previous mesh instance buffer. This is wasteful, as we only ever use the transform for motion blur.This patch fixes the issue by introducing a new type,
PreviousMeshInputUniform, that contains only the transform. Not only does this improve performance, but it will also simplify future work to sparsely update only theMeshInputUniformfields that changed.On
bevy_city --no-cpu-culling, this commit reduceswrite_previous_input_buffersfrom a median time of 240.1 μs to 65.33 μs, a 3.68× speedup.