feat: get_estimated_fees

Author: Insmael

cryptomarket/args.py

@@ -178,6 +178,13 @@ class OrderRequest:
     make_rate: Optional[str] = None
 
 
+@dataclass
+class FeeRequest:
+    currency: str
+    amount: str
+    network_code: Optional[str] = None
+
+
 @dataclass
 class ACLSettings:
     sub_account_id: str = None
@@ -445,6 +452,9 @@ def subscription_mode(self, val: str):
     def target_currency(self, val: str):
         return self.add('target_currency', val)
 
+    def preferred_network(self, val: str):
+        return self.add('preferred_network', val)
+
     def type(self, val: str):
         return self.add('type', val)
 

cryptomarket/client.py

@@ -1,3 +1,4 @@
+from dataclasses import asdict
 from enum import Enum
 from typing import Any, Dict, List, Optional, Union
 
@@ -8,7 +9,7 @@
 from cryptomarket.dataclasses import (Address, AmountLock, Balance, Candle,
                                       Commission, Currency, Order, OrderBook,
                                       Price, PriceHistory, SubAccount, Symbol,
-                                      Ticker, Trade, Transaction)
+                                      Ticker, Trade, Transaction, Fee)
 from cryptomarket.dataclasses.aclSettings import ACLSettings
 from cryptomarket.dataclasses.publicTrade import PublicTrade
 from cryptomarket.http_client import HttpClient
@@ -52,18 +53,20 @@ def _delete(self, endpoint: str, params=None):
 
     # PUBLIC METHOD CALLS
 
-    def get_currencies(self, currencies: List[str] = None) -> Dict[str, Currency]:
+    def get_currencies(self, currencies: List[str] = None, preferred_network: Optional[str] = None) -> Dict[str, Currency]:
         """Get a dict of all currencies or specified currencies
 
         Requires no API key Access Rights
 
         https://api.exchange.cryptomkt.com/#currencies
 
         :param currencies: Optional. A list of currencies ids
+        :param preferred_network: Optional. Code of the default network for currencies
 
         :returns: A dict of available currencies. indexed by currency id
         """
-        params = args.DictBuilder().currencies(currencies).build()
+        params = args.DictBuilder().currencies(
+            currencies).preferred_network(preferred_network).build()
         response = self._get(endpoint='public/currency', params=params)
         return {key: from_dict(data_class=Currency, data=response[key])
                 for key in response}
@@ -981,6 +984,20 @@ def get_estimate_withdrawal_fee(self, currency: str, amount: str) -> str:
         params = args.DictBuilder().amount(amount).currency(currency).build()
         return self._get(endpoint='wallet/crypto/fee/estimate', params=params)['fee']
 
+    def get_estimate_withdrawal_fees(self, fee_requests: List[args.FeeRequest]) -> List[Fee]:
+        """Get a list of estimates of withdrawal fees
+
+        Requires the "Payment information" API key Access Right
+
+        https://api.exchange.cryptomkt.com/#estimate-withdraw-fee
+
+        :returns: A list of expected withdrawal fees
+        """
+        params = [asdict(fee_request) for fee_request in fee_requests]
+        result = self._post(
+            endpoint='wallet/crypto/fees/estimate', params=params)
+        return [Fee.from_dict(fee_data) for fee_data in result]
+
     def check_if_crypto_address_belong_to_current_account(self, address: str) -> bool:
         """Check if an address is from this account
 

cryptomarket/dataclasses/__init__.py

@@ -30,6 +30,7 @@
 from .wsTicker import WSTicker
 from .wsTrade import WSTrade
 from .wsPriceRate import WSPriceRate
+from .fee import Fee
 __all__ = [
     ACLSettings,
     Address,
@@ -63,5 +64,6 @@
     WSTicker,
     WSTrade,
     WSPriceRate,
-    SubAccount
+    SubAccount, 
+    Fee,
 ]

cryptomarket/dataclasses/fee.py

@@ -0,0 +1,16 @@
+from dataclasses import dataclass
+from typing import Any, Dict, List
+
+from cryptomarket.dataclasses.orderBookLevel import OrderBookLevel
+
+
+@dataclass
+class Fee:
+    fee: str
+    network_fee: str
+    amount: str
+    currency: str
+
+    @classmethod
+    def from_dict(cls, data: Dict[str, Any]):
+        return cls(data.get('fee'), data.get('networkFee'), data.get('amount'), data.get('currency'))

tests/rest/test_helpers.py

@@ -7,6 +7,7 @@
                                       OrderBook, OrderBookLevel, Price,
                                       PriceHistory, PricePoint, PublicTrade,
                                       Symbol, Ticker, Transaction)
+from cryptomarket.dataclasses.fee import Fee
 
 
 # defined checks if a key is present in a dict, and if its value is str, checks if its defined.
@@ -104,6 +105,18 @@ def good_symbol(symbol: Symbol) -> bool:
     )
 
 
+def good_fee(fee: Fee) -> bool:
+    return good_dict(
+        asdict(fee),
+        [
+            "fee",
+            "network_fee",
+            "amount",
+            "currency",
+        ]
+    )
+
+
 def good_ticker(ticker: Ticker) -> bool:
     return good_dict(
         asdict(ticker),

tests/rest/test_wallet_management.py

@@ -134,6 +134,15 @@ def test_successfull_call(self):
         if not success:
             self.fail("not a successful rollback")
 
+class TestGetEstimateWithdrawalFees(AuthCallsTestCase):
+    def test_successfull_call(self):
+        fees = self.client.get_estimate_withdrawal_fees([
+            args.FeeRequest("EOS", "123"),
+            args.FeeRequest("ETH", "22"),
+        ])
+        if not good_list(good_fee, fees):
+            self.fail("not a good fee")
+
 
 class TestGetEstimateWithdrawalFee(AuthCallsTestCase):
     def test_successfull_call(self):