Skip to content

Commit f61de88

Browse files
authored
Merge pull request #2444 from timo-klarshift/issue-2443-fix-local-registry-rebuild
fix: Prevent constant rebuilding with local registry
2 parents e1d27b9 + 2e80dbc commit f61de88

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

pkg/devspace/build/builder/buildkit/buildkit.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func (b *Builder) Build(ctx devspacecontext.Context) error {
6868
func (b *Builder) ShouldRebuild(ctx devspacecontext.Context, forceRebuild bool) (bool, error) {
6969
// Check if image is present in local registry
7070
imageCache, _ := ctx.Config().LocalCache().GetImageCache(b.helper.ImageConfigName)
71-
imageName := imageCache.ResolveImage()
71+
imageName := imageCache.ResolveImage() + ":" + imageCache.Tag
7272

7373
if imageCache.IsLocalRegistryImage() {
7474
found, err := registry.IsImageAvailableRemotely(ctx.Context(), imageName)

pkg/devspace/build/builder/docker/docker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func (b *Builder) Build(ctx devspacecontext.Context) error {
7575
func (b *Builder) ShouldRebuild(ctx devspacecontext.Context, forceRebuild bool) (bool, error) {
7676
// Check if image is present in local registry
7777
imageCache, _ := ctx.Config().LocalCache().GetImageCache(b.helper.ImageConfigName)
78-
imageName := imageCache.ResolveImage()
78+
imageName := imageCache.ResolveImage() + ":" + imageCache.Tag
7979

8080
if imageCache.IsLocalRegistryImage() {
8181
found, err := registry.IsImageAvailableRemotely(ctx.Context(), imageName)

0 commit comments

Comments
 (0)