Skip to content

fix(a11y): drop role=textbox / aria-multiline from innerdocbody (#7778) #7782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
May 16, 2026
+22 −2
Merged

fix(a11y): drop role=textbox / aria-multiline from innerdocbody (#7778) #7782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/static/js/ace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,12 @@ const Ace2Editor = function () {
// <body> tag
innerDocument.body.id = 'innerdocbody';
innerDocument.body.classList.add('innerdocbody');
innerDocument.body.setAttribute('role', 'textbox');
innerDocument.body.setAttribute('aria-multiline', 'true');
// Deliberately no role="textbox" / aria-multiline: those put NVDA/JAWS
// into focus mode (the whole pad becomes one flat edit field), which
// hides links and headings from the rotor and suppresses arrow-key
// line navigation. contenteditable=true already tells AT this is
// editable; without textbox semantics AT can browse the content as a
// document. See #7778 / #7255.
innerDocument.body.setAttribute('aria-label', 'Pad content');
innerDocument.body.setAttribute('aria-describedby', 'editor-keyboard-hint');
innerDocument.body.setAttribute('spellcheck', 'false');
Expand Down
16 changes: 16 additions & 0 deletions src/tests/frontend-new/specs/a11y_dialogs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,22 @@ test('editor-keyboard-hint exists in the editor iframe with localized text (#725
expect(text).toContain('Escape');
});

test('innerdocbody does not advertise role=textbox / aria-multiline (#7778)', async ({page}) => {
// role=textbox + aria-multiline force NVDA/JAWS into focus mode for the
// whole pad, which hides links/headings from the rotor and stops
// arrow-key line navigation. Keep these attributes absent so AT browses
// the editor as document content. The aria-label / aria-describedby
// (#editor-keyboard-hint) stay — they don't change AT mode.
const innerFrame = page.frameLocator('iframe[name="ace_outer"]')
.frameLocator('iframe[name="ace_inner"]');
const body = innerFrame.locator('body#innerdocbody');
await expect(body).toHaveCount(1);
expect(await body.getAttribute('role')).toBeNull();
expect(await body.getAttribute('aria-multiline')).toBeNull();
await expect(body).toHaveAttribute('aria-label', 'Pad content');
await expect(body).toHaveAttribute('aria-describedby', 'editor-keyboard-hint');
});

test('line-number sidediv is hidden from screen readers (#7255)', async ({page}) => {
// sidediv lives in the outer ace iframe (ace_outer) — query the frame.
const outerFrame = page.frameLocator('iframe[name="ace_outer"]');
Expand Down
Loading