Commit 402001f
Add missing stream state properties to Flow defs (#56224)
Summary:
Pull Request resolved: #56224
Add standard Node.js stream properties to the Flow type definitions for `stream$Readable` and `stream$Writable` that were previously missing:
- `stream$Readable`:
- [`closed: boolean`](https://nodejs.org/api/stream.html#readableclosed)
- [`destroyed: boolean`](https://nodejs.org/api/stream.html#readabledestroyed)
- [`errored: ?Error`](https://nodejs.org/api/stream.html#readableerrored)
- [`readableEnded: boolean`](https://nodejs.org/api/stream.html#readablereadableended)
- [`readableAborted: boolean`](https://nodejs.org/api/stream.html#readablereadableaborted)
- [`readableDidRead: boolean`](https://nodejs.org/api/stream.html#readablereadabledidread)
- [`readableFlowing: ?boolean`](https://nodejs.org/api/stream.html#readablereadableflowing)
- [`readableObjectMode: boolean`](https://nodejs.org/api/stream.html#readablereadableobjectmode)
- `stream$Writable`:
- [`closed: boolean`](https://nodejs.org/api/stream.html#writableclosed)
- [`destroyed: boolean`](https://nodejs.org/api/stream.html#writabledestroyed)
- [`errored: ?Error`](https://nodejs.org/api/stream.html#writableerrored)
- [`writableEnded: boolean`](https://nodejs.org/api/stream.html#writablewritableended)
- [`writableAborted: boolean`](https://nodejs.org/api/stream.html#writablewritableaborted)
- [`writableFinished: boolean`](https://nodejs.org/api/stream.html#writablewritablefinished)
- [`writableNeedDrain: boolean`](https://nodejs.org/api/stream.html#writablewritableneeddrain)
- [`writableObjectMode: boolean`](https://nodejs.org/api/stream.html#writablewritableobjectmode)
Docs: https://nodejs.org/api/stream.html
These properties exist on all Node.js streams and are needed by Metro to detect when HTTP response streams have been closed by a client disconnect.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D98176491
fbshipit-source-id: 2407367c52e5ece9099289ffd18642bdc4a7047d1 parent 6e7797d commit 402001f
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3610 | 3610 | | |
3611 | 3611 | | |
3612 | 3612 | | |
| 3613 | + | |
3613 | 3614 | | |
| 3615 | + | |
| 3616 | + | |
3614 | 3617 | | |
3615 | 3618 | | |
3616 | 3619 | | |
3617 | 3620 | | |
3618 | 3621 | | |
| 3622 | + | |
| 3623 | + | |
| 3624 | + | |
| 3625 | + | |
3619 | 3626 | | |
3620 | 3627 | | |
| 3628 | + | |
3621 | 3629 | | |
3622 | 3630 | | |
3623 | 3631 | | |
| |||
3662 | 3670 | | |
3663 | 3671 | | |
3664 | 3672 | | |
| 3673 | + | |
3665 | 3674 | | |
3666 | 3675 | | |
| 3676 | + | |
3667 | 3677 | | |
3668 | 3678 | | |
3669 | 3679 | | |
3670 | 3680 | | |
3671 | 3681 | | |
3672 | 3682 | | |
3673 | 3683 | | |
| 3684 | + | |
3674 | 3685 | | |
3675 | 3686 | | |
3676 | 3687 | | |
| 3688 | + | |
| 3689 | + | |
| 3690 | + | |
3677 | 3691 | | |
3678 | 3692 | | |
| 3693 | + | |
| 3694 | + | |
3679 | 3695 | | |
3680 | 3696 | | |
3681 | 3697 | | |
| |||
0 commit comments