Skip to content

Commit 9ef7738

Browse files
coadometa-codesync[bot]
authored andcommitted
Exclude Apple Switch component from the ReactAndroid C++ API snapshot
Summary: Prevents iOS Switch component leaking into the ReactAndroid snapshot by adding `*/components/switch/iosswitch/*` path to the `exclude_patterns` in the parser config. Changelog: [Internal] Differential Revision: D98473064
1 parent 6c87461 commit 9ef7738

3 files changed

Lines changed: 1 addition & 26 deletions

File tree

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponen
454454
const char facebook::react::AndroidProgressBarComponentName[];
455455
const char facebook::react::AndroidSwitchComponentName[];
456456
const char facebook::react::AndroidTextInputComponentName[];
457-
const char facebook::react::AppleSwitchComponentName[];
458457
const char facebook::react::ImageComponentName[];
459458
const char facebook::react::ImageFetcherKey[];
460459
const char facebook::react::ImageManagerKey[];
@@ -4911,11 +4910,6 @@ class facebook::react::SurfaceTelemetry {
49114910
public void incorporate(const facebook::react::TransactionTelemetry& telemetry, int numberOfMutations);
49124911
}
49134912

4914-
class facebook::react::SwitchComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::SwitchShadowNode> {
4915-
public SwitchComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
4916-
public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
4917-
}
4918-
49194913
class facebook::react::SwitchEventEmitter : public facebook::react::BaseViewEventEmitter {
49204914
public void onChange(facebook::react::SwitchEventEmitter::OnChange value) const;
49214915
}
@@ -4940,13 +4934,6 @@ class facebook::react::SwitchProps : public facebook::react::HostPlatformViewPro
49404934
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
49414935
}
49424936

4943-
class facebook::react::SwitchShadowNode : public facebook::react::ConcreteViewShadowNode<facebook::react::AppleSwitchComponentName, facebook::react::SwitchProps, facebook::react::SwitchEventEmitter> {
4944-
public SwitchShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
4945-
public SwitchShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
4946-
public static facebook::react::ShadowNodeTraits BaseTraits();
4947-
public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const override;
4948-
}
4949-
49504937
class facebook::react::TaskPriorityComparer {
49514938
public bool operator()(const std::shared_ptr<facebook::react::Task>& lhs, const std::shared_ptr<facebook::react::Task>& rhs);
49524939
}

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponen
454454
const char facebook::react::AndroidProgressBarComponentName[];
455455
const char facebook::react::AndroidSwitchComponentName[];
456456
const char facebook::react::AndroidTextInputComponentName[];
457-
const char facebook::react::AppleSwitchComponentName[];
458457
const char facebook::react::ImageComponentName[];
459458
const char facebook::react::ImageFetcherKey[];
460459
const char facebook::react::ImageManagerKey[];
@@ -4902,11 +4901,6 @@ class facebook::react::SurfaceTelemetry {
49024901
public void incorporate(const facebook::react::TransactionTelemetry& telemetry, int numberOfMutations);
49034902
}
49044903

4905-
class facebook::react::SwitchComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::SwitchShadowNode> {
4906-
public SwitchComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
4907-
public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
4908-
}
4909-
49104904
class facebook::react::SwitchEventEmitter : public facebook::react::BaseViewEventEmitter {
49114905
public void onChange(facebook::react::SwitchEventEmitter::OnChange value) const;
49124906
}
@@ -4931,13 +4925,6 @@ class facebook::react::SwitchProps : public facebook::react::HostPlatformViewPro
49314925
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
49324926
}
49334927

4934-
class facebook::react::SwitchShadowNode : public facebook::react::ConcreteViewShadowNode<facebook::react::AppleSwitchComponentName, facebook::react::SwitchProps, facebook::react::SwitchEventEmitter> {
4935-
public SwitchShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
4936-
public SwitchShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
4937-
public static facebook::react::ShadowNodeTraits BaseTraits();
4938-
public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const override;
4939-
}
4940-
49414928
class facebook::react::TaskPriorityComparer {
49424929
public bool operator()(const std::shared_ptr<facebook::react::Task>& lhs, const std::shared_ptr<facebook::react::Task>& rhs);
49434930
}

scripts/cxx-api/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ platforms:
4343
- packages/react-native/ReactAndroid
4444
exclude_patterns:
4545
- "*/ReactAndroid/src/main/jni/react/featureflags/*"
46+
- "*/components/switch/iosswitch/*"
4647
- "*/platform/cxx/*"
4748
- "*/platform/windows/*"
4849
- "*/platform/macos/*"

0 commit comments

Comments
 (0)